Allow specifying different alignment for grob and its parent

Allow specifying different alignment for grob and its parent

This gives users more possibilities for grob positioning - for example,
they can align left edge of a grob on center of its parent, etc.

[lemzwerg, 2014-07-21 00:28:04]

LGTM.

https://codereview.appspot.com/118950043/diff/1/scm/define-grob-properties.scm
File scm/define-grob-properties.scm (right):

https://codereview.appspot.com/118950043/diff/1/scm/define-grob-properties.sc...
scm/define-grob-properties.scm:814: Value @w{@code{-1}} means left aligned,
@code{0}@tie{}centered, and
... value@tie{}@code{-1} ...

https://codereview.appspot.com/118950043/diff/1/scm/define-grob-properties.sc...
scm/define-grob-properties.scm:818: setting @code{LyricText} alignment to
@code{'(-1 . 1)} will result in
... will result in a ...

[janek, 2014-07-21 06:02:31]

address Werner's comments

[janek, 2014-07-21 06:03:06]

Fixed. Thanks for review!

https://codereview.appspot.com/118950043/diff/1/scm/define-grob-properties.scm
File scm/define-grob-properties.scm (right):

https://codereview.appspot.com/118950043/diff/1/scm/define-grob-properties.sc...
scm/define-grob-properties.scm:814: Value @w{@code{-1}} means left aligned,
@code{0}@tie{}centered, and
On 2014/07/21 00:28:03, lemzwerg wrote:
> ... value@tie{}@code{-1} ...

Done.

https://codereview.appspot.com/118950043/diff/1/scm/define-grob-properties.sc...
scm/define-grob-properties.scm:818: setting @code{LyricText} alignment to
@code{'(-1 . 1)} will result in
On 2014/07/21 00:28:04, lemzwerg wrote:
> ... will result in a ...

Done.

[david.nalesnik, 2014-07-23 14:45:50]

Do you think a regtest would be appropriate?

LGTM.  A natural extension of self-alignment capabilities.

P.S. Can you suggest an application of self-alignment-Y?

[david.nalesnik, 2014-07-23 14:52:23]

On Wed, Jul 23, 2014 at 9:45 AM, <david.nalesnik@gmail.com> wrote:
>
>
> P.S. Can you suggest an application of self-alignment-Y?
>
>
Forget that--I see an application in NR 5.5.1.

[janek, 2014-07-23 21:25:09]

2014-07-23 16:45 GMT+02:00  <david.nalesnik@gmail.com>:
> Do you think a regtest would be appropriate?

Definitely!  I'll add it when i have a spare moment.

> LGTM.  A natural extension of self-alignment capabilities.

thanks!

[janek, 2014-07-26 18:32:34]

add regtest

[janek, 2014-07-26 18:38:52]

fix comment

[janek, 2014-07-26 21:12:29]

add missing @

[janek, 2014-08-01 16:55:46]

Use separate properties for self- and parent-alignment

[janek, 2014-08-01 17:01:24]

fill in missing interfaces

[dak, 2014-08-01 17:08:48]

https://codereview.appspot.com/118950043/diff/100001/lily/self-alignment-inte...
File lily/self-alignment-interface.cc (right):

https://codereview.appspot.com/118950043/diff/100001/lily/self-alignment-inte...
lily/self-alignment-interface.cc:139: if (robust_scm2string(par_align, "") ==
"same-as-self-alignment")
That's too ugly to live.  Shouldn't you be able to use a callback here?  Look at
grob::inherit-parent-property for inspiration, that's basically what you need
here apart from looking up the parent.

[janek, 2014-08-01 19:11:29]

use a callback for synchronizing parent- and self-alignment

[janek, 2014-08-01 19:13:18]

How do you like it now?

https://codereview.appspot.com/118950043/diff/100001/lily/self-alignment-inte...
File lily/self-alignment-interface.cc (right):

https://codereview.appspot.com/118950043/diff/100001/lily/self-alignment-inte...
lily/self-alignment-interface.cc:139: if (robust_scm2string(par_align, "") ==
"same-as-self-alignment")
On 2014/08/01 17:08:48, dak wrote:
> That's too ugly to live.  Shouldn't you be able to use a callback here?  Look
at
> grob::inherit-parent-property for inspiration, that's basically what you need
> here apart from looking up the parent.

Done.  Thanks for the inspiration.

[janek, 2014-08-01 19:21:20]

remove stuff that i missed with previous patchset

[janek, 2014-08-01 19:22:43]

i hope this is the last thing i missed.

[janek, 2014-08-02 07:25:01]

restore old behaviour everywhere.y

[janek, 2014-08-02 09:56:38]

don't use grob::copy-property; copy from self-alignment if unset

[janek, 2014-08-09 19:36:15]

Pushed as two commits (to differentiate between new functionality and restoring
old behaviour):

commit d7b067b15ae975ee52f91bd674cc667baa09eb04
Author: Janek Warchoł <lemniskata.bernoullego@gmail.com>
Date:   Sat Aug 9 21:08:08 2014 +0200

    Grob alignment: get back 2.19.9 behaviour
    
    A series of commits
    
    *   0bc7f77 Issue 3978: Merge alignment cleanup
    |\
    | * d6604b0 define-grobs.scm: reorder properties alphabetically
    | * 6f3f8f0 TextScript, CombineTextScript: use aligned_on_parent
    | * 1d76502 Replace XY-offset closures with aligned_on_parent where possible
    | * 09412c2 Clean up DynamicText horizontal alignment.
    |/
    
    changed how some grobs (notably DynamicTexts) reacted to overriding
    self-alignment-X property.  The new behaviour was confusing for some
    users, so this commit gets back the old behaviour.  The possibility
    of using separate alignment factors for grob and its parent, introduced
    by previous commit (see Issue 4022), makes it possible to get pre-0bc7f77
    behaviour just by changing default values of parent-alignment-*; leaving
    up the possibility to easily change them in the future.
    
    See http://lists.gnu.org/archive/html/lilypond-user/2014-07/msg00691.html
    and https://code.google.com/p/lilypond/issues/detail?id=4036
    for details.

commit 0c4f221e5d4656abd47f067907611df200fbfc20
Author: Janek Warchoł <lemniskata.bernoullego@gmail.com>
Date:   Sun Jul 20 20:07:16 2014 +0200

    Issue 4022: Allow specifying different alignment for grob and its parent
    
    This gives users more possibilities for grob positioning - for example,
    they can align left edge of a grob on center of its parent, etc.
    
    Also fix Issue 4054.