Issue 118043: Renaming of packing to shipment (purchase_invoice_line_standalone)

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 118043: Renaming of packing to shipment (purchase_invoice_line_standalone) (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
16 years, 8 months ago by bch

Modified:
16 years, 8 months ago

Reviewers:
ced1

Visibility:
Public.

Patch Set 2 : Use module_name #

Total comments: 1

Patch Set 4 : Use psycopg escaping #

Created: 16 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -3 lines)			Patch
	M	purchase.py	View	1 2 3	1 chunk	+9 lines, -0 lines	0 comments	Download
	M	purchase.xml	View		1 chunk	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 9

Expand All Messages | Collapse All Messages

ced1

http://codereview.appspot.com/118043/diff/1/2 File purchase.py (right): http://codereview.appspot.com/118043/diff/1/2#newcode20 Line 20: "AND module = 'purchase_invoice_line_standalone'") You should use module_name ...

16 years, 8 months ago (2009-09-17 07:55:09 UTC) #2

ced1

http://codereview.appspot.com/118043/diff/1003/1004 File purchase.py (right): http://codereview.appspot.com/118043/diff/1003/1004#newcode20 Line 20: "AND module = '" + module_name + "'") ...

16 years, 8 months ago (2009-09-17 08:47:18 UTC) #4

ced1

http://codereview.appspot.com/118043/diff/9/10 File purchase.py (right): http://codereview.appspot.com/118043/diff/9/10#newcode20 Line 20: "AND module = '%s'" % module_name) No: "AND ...

16 years, 8 months ago (2009-09-17 08:51:53 UTC) #6

Can be closed

Expand All Messages | Collapse All Messages