Issue 117680044: code review 117680044: runtime: shorten hash declarations

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 117680044: code review 117680044: runtime: shorten hash declarations (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 9 months ago by khr

Modified:
10 years, 9 months ago

Reviewers:
gobot, iant

CC:
dvyukov, iant, golang-codereviews

Visibility:
Public.

Patch Set 2 : diff -r 37cd24716bed45f655a17ffdc06d769135c77191 https://khr%40golang.org@code.google.com/p/go/ #

Patch Set 3 : diff -r 37cd24716bed45f655a17ffdc06d769135c77191 https://khr%40golang.org@code.google.com/p/go/ #

Patch Set 4 : diff -r 37cd24716bed45f655a17ffdc06d769135c77191 https://khr%40golang.org@code.google.com/p/go/ #

Patch Set 5 : diff -r fc7539d17fd797a1d317c30f5a78e62cb28a6b66 https://khr%40golang.org@code.google.com/p/go/ #

Patch Set 6 : diff -r fc7539d17fd797a1d317c30f5a78e62cb28a6b66 https://khr%40golang.org@code.google.com/p/go/ #

Patch Set 7 : diff -r fc7539d17fd797a1d317c30f5a78e62cb28a6b66 https://khr%40golang.org@code.google.com/p/go/ #

Patch Set 8 : diff -r fc7539d17fd797a1d317c30f5a78e62cb28a6b66 https://khr%40golang.org@code.google.com/p/go/ #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -19 lines)			Patch
	M	src/cmd/api/goapi.go	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	src/pkg/runtime/alg.go	View		7 chunks	+16 lines, -18 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

khr

Hello dvyukov@google.com (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://khr%40golang.org@code.google.com/p/go/

10 years, 9 months ago (2014-08-06 20:22:07 UTC) #1

khr

*** Submitted as https://code.google.com/p/go/source/detail?r=6b679288e862 *** runtime: shorten hash declarations LGTM=iant R=dvyukov, iant CC=golang-codereviews https://codereview.appspot.com/117680044

10 years, 9 months ago (2014-08-06 20:42:04 UTC) #3

gobot

10 years, 9 months ago (2014-08-07 08:47:42 UTC) #4

Message was sent while issue was closed.

This CL appears to have broken the freebsd-amd64-race builder.
See http://build.golang.org/log/58ccf8a0fdbd62867c06ac6707f591979609369b

Expand All Messages | Collapse All Messages