Issue 11723043: various: fix test races

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 11723043: various: fix test races

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 9 months ago by rog

Modified:
10 years, 9 months ago

Reviewers:
dimitern, mp+176444, fwereade

Visibility:
Public.

Description

various: fix test races These are various places that rely on testing.ShortWait to wait for something to occur. I discovered them by setting testing.ShortWait to 1us and seeing what failed. https://code.launchpad.net/~rogpeppe/juju-core/344-fix-test-timeouts-2/+merge/176444 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : various: fix test races #

Patch Set 3 : various: fix test races #

Total comments: 1

Patch Set 4 : various: fix test races #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+64 lines, -15 lines)			Patch
A	[revision details]	View	1 2 3	1 chunk	+2 lines, -0 lines	0 comments	Download
M	cmd/jujud/machine_test.go	View	1 2 3	1 chunk	+11 lines, -2 lines	0 comments	Download
M	state/watcher/watcher_test.go	View		4 chunks	+43 lines, -12 lines	0 comments	Download
M	testing/constants.go	View	1 2 3	2 chunks	+7 lines, -0 lines	0 comments	Download
M	worker/uniter/jujuc/server_test.go	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

dimitern

LGTM with a suggestion. https://codereview.appspot.com/11723043/diff/5001/testing/constants.go File testing/constants.go (right): https://codereview.appspot.com/11723043/diff/5001/testing/constants.go#newcode7 testing/constants.go:7: "launchpad.net/juju-core/utils" "time" "launchpad.net/juju-core/utils" Please.

10 years, 9 months ago (2013-07-24 10:51:54 UTC) #2

Please take a look.

Expand All Messages | Collapse All Messages