Issue 117190043: code review 117190043: go.talks: Fix a typo and increase size of array to get ...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 117190043: code review 117190043: go.talks: Fix a typo and increase size of array to get ... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 9 months ago by francesc

Modified:
9 years, 9 months ago

Reviewers:
adg

CC:
adg, fresh.grass.yum, golang-codereviews

Visibility:
Public.

Description

go.talks: Fix a typo and increase size of array to get heap error. Right now we get a [process took too long] error, which doesn't prove the point.

Patch Set 1 #

Patch Set 2 : diff -r 82099a46b838 https://code.google.com/p/go.talks #

Patch Set 3 : diff -r 82099a46b838 https://code.google.com/p/go.talks #

Patch Set 4 : diff -r 82099a46b838 https://code.google.com/p/go.talks #

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	2014/playground.slide	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	2014/playground/heap.go	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

francesc

Hello adg@golang.org, fresh.grass.yum@gmail.com (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.talks

9 years, 9 months ago (2014-07-24 23:22:01 UTC) #1

francesc

9 years, 9 months ago (2014-07-25 00:42:17 UTC) #3

*** Submitted as
https://code.google.com/p/go/source/detail?r=ad18f921c027&repo=talks ***

go.talks: Fix a typo and increase size of array to get heap error.

Right now we get a [process took too long] error, which doesn't prove the point.

LGTM=adg
R=adg, fresh.grass.yum
CC=golang-codereviews
https://codereview.appspot.com/117190043

Expand All Messages | Collapse All Messages