Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(186)

Issue 117190043: code review 117190043: go.talks: Fix a typo and increase size of array to get ... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 6 months ago by francesc
Modified:
6 years, 6 months ago
Reviewers:
adg
CC:
adg, fresh.grass.yum, golang-codereviews
Visibility:
Public.

Description

go.talks: Fix a typo and increase size of array to get heap error. Right now we get a [process took too long] error, which doesn't prove the point.

Patch Set 1 #

Patch Set 2 : diff -r 82099a46b838 https://code.google.com/p/go.talks #

Patch Set 3 : diff -r 82099a46b838 https://code.google.com/p/go.talks #

Patch Set 4 : diff -r 82099a46b838 https://code.google.com/p/go.talks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M 2014/playground.slide View 1 chunk +1 line, -1 line 0 comments Download
M 2014/playground/heap.go View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
francesc
Hello adg@golang.org, fresh.grass.yum@gmail.com (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.talks
6 years, 6 months ago (2014-07-24 23:22:01 UTC) #1
adg
LGTM
6 years, 6 months ago (2014-07-25 00:31:59 UTC) #2
francesc
6 years, 6 months ago (2014-07-25 00:42:17 UTC) #3
*** Submitted as
https://code.google.com/p/go/source/detail?r=ad18f921c027&repo=talks ***

go.talks: Fix a typo and increase size of array to get heap error.

Right now we get a [process took too long] error, which doesn't prove the point.

LGTM=adg
R=adg, fresh.grass.yum
CC=golang-codereviews
https://codereview.appspot.com/117190043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b