Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(424)

Issue 117046: Ns-3 Nix-vector Routing (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 7 months ago by Josh Pelkey
Modified:
11 years, 1 month ago
CC:
ns-3-reviews_googlegroups.com, riley_ece.gatech.edu
Visibility:
Public.

Patch Set 1 #

Total comments: 41

Patch Set 2 : Cleanup after Craig's initial review. #

Total comments: 2

Patch Set 3 : Revisions after Tom's review #

Patch Set 4 : Missed a few stray comments that were irrelevant #

Total comments: 1

Patch Set 5 : Update after Mathieu's Review #

Total comments: 2

Patch Set 6 : Documentation of NixVector in packet #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2401 lines, -3 lines) Patch
M AUTHORS View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M CHANGES.html View 1 2 3 4 1 chunk +11 lines, -0 lines 0 comments Download
M RELEASE_NOTES View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
A examples/nix-simple.cc View 1 1 chunk +114 lines, -0 lines 0 comments Download
A examples/nms-p2p-nix.cc View 1 2 1 chunk +458 lines, -0 lines 0 comments Download
M examples/wscript View 1 chunk +8 lines, -0 lines 0 comments Download
A src/common/nix-vector.h View 1 2 3 4 1 chunk +166 lines, -0 lines 0 comments Download
A src/common/nix-vector.cc View 1 2 3 4 1 chunk +419 lines, -0 lines 0 comments Download
M src/common/packet.h View 1 2 3 4 5 3 chunks +14 lines, -0 lines 0 comments Download
M src/common/packet.cc View 1 2 3 4 8 chunks +22 lines, -2 lines 0 comments Download
M src/common/wscript View 1 2 3 4 2 chunks +2 lines, -0 lines 0 comments Download
A src/helper/ipv4-nix-vector-helper.h View 1 chunk +55 lines, -0 lines 0 comments Download
A src/helper/ipv4-nix-vector-helper.cc View 1 chunk +39 lines, -0 lines 0 comments Download
M src/helper/wscript View 1 2 3 4 5 3 chunks +3 lines, -1 line 0 comments Download
A src/routing/nix-vector-routing/ipv4-nix-vector-routing.h View 1 2 1 chunk +157 lines, -0 lines 0 comments Download
A src/routing/nix-vector-routing/ipv4-nix-vector-routing.cc View 1 2 3 1 chunk +840 lines, -0 lines 0 comments Download
A src/routing/nix-vector-routing/nix-vector-routing.h View 1 2 1 chunk +71 lines, -0 lines 0 comments Download
A src/routing/nix-vector-routing/waf View 2 1 chunk +1 line, -0 lines 0 comments Download
A src/routing/nix-vector-routing/wscript View 1 chunk +15 lines, -0 lines 0 comments Download
M src/wscript View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8
craigdo
Took a quick look at this before starting other business. http://codereview.appspot.com/117046/diff/1/5 File examples/nix-simple.cc (right): http://codereview.appspot.com/117046/diff/1/5#newcode67 ...
11 years, 7 months ago (2009-09-11 22:38:17 UTC) #1
Josh Pelkey
Cleanup after Craig's initial review. Patch set 2 posted. http://codereview.appspot.com/117046/diff/1/5 File examples/nix-simple.cc (right): http://codereview.appspot.com/117046/diff/1/5#newcode67 Line ...
11 years, 7 months ago (2009-09-12 18:34:14 UTC) #2
Tom Henderson
Summary of main open issues I found: 1) does not correctly handle bridge devices. 2) ...
11 years, 7 months ago (2009-09-14 03:59:44 UTC) #3
Josh Pelkey
http://codereview.appspot.com/117046/diff/1/18 File src/routing/nix-vector-routing/ipv4-nix-vector-routing.cc (right): http://codereview.appspot.com/117046/diff/1/18#newcode116 Line 116: if (BuildNixVector (parentVector, source->GetId (), destNode->GetId (), nixVector)) ...
11 years, 7 months ago (2009-09-15 04:12:54 UTC) #4
Tom Henderson
http://codereview.appspot.com/117046/diff/1/18 File src/routing/nix-vector-routing/ipv4-nix-vector-routing.cc (right): http://codereview.appspot.com/117046/diff/1/18#newcode616 Line 616: {} Could this be due to > nix-vector ...
11 years, 7 months ago (2009-09-15 04:20:52 UTC) #5
Mathieu Lacage
I am not sure why you have put this in the packet metadata class. This ...
11 years, 7 months ago (2009-09-15 10:56:11 UTC) #6
Josh Pelkey
On 2009/09/15 10:56:11, Mathieu Lacage wrote: > I am not sure why you have put ...
11 years, 7 months ago (2009-09-15 17:03:17 UTC) #7
Mathieu Lacage
11 years, 6 months ago (2009-09-17 08:10:01 UTC) #8
The patch looks good for merging.

+1

http://codereview.appspot.com/117046/diff/116/1132
File src/common/packet.h (right):

http://codereview.appspot.com/117046/diff/116/1132#newcode31
Line 31: #include "nix-vector.h"
you don't need the include because you have a Ptr<> only. Just add a forward
declaration of NixVector below

http://codereview.appspot.com/117046/diff/116/1132#newcode38
Line 38: 
here, add:
class NixVector;
and it should still work if you include nix-vector.h from packet.cc
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b