Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(31)

Issue 11669043: code review 11669043: [release-branch.go1.1] cmd/gc: fix issue with method wr... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 4 months ago by adg
Modified:
9 years, 4 months ago
Reviewers:
dfc
CC:
golang-dev, dfc
Visibility:
Public.

Description

[release-branch.go1.1] cmd/gc: fix issue with method wrappers not having escape analysis run on them. ««« CL 10383048 / 58e15340e78f cmd/gc: fix issue with method wrappers not having escape analysis run on them. Escape analysis needs the right curfn value on a dclfunc node, otherwise it will not analyze the function. When generating method value wrappers, we forgot to set the curfn correctly. Fixes issue 5753. R=golang-dev, rsc CC=golang-dev https://codereview.appspot.com/10383048 »»» Update issue 5928

Patch Set 1 #

Patch Set 2 : diff -r 2de1a6879076 https://code.google.com/p/go #

Patch Set 3 : diff -r 2de1a6879076 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -1 line) Patch
M src/cmd/gc/closure.c View 1 4 chunks +6 lines, -1 line 0 comments Download
A test/fixedbugs/issue5753.go View 1 1 chunk +29 lines, -0 lines 0 comments Download

Messages

Total messages: 4
adg
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
9 years, 4 months ago (2013-07-22 08:44:39 UTC) #1
dfc
Just waiting for a few more builders to report in. On Mon, Jul 22, 2013 ...
9 years, 4 months ago (2013-07-22 10:14:06 UTC) #2
dfc
LGTM. On Mon, Jul 22, 2013 at 8:14 PM, Dave Cheney <dave@cheney.net> wrote: > Just ...
9 years, 4 months ago (2013-07-22 10:54:19 UTC) #3
adg
9 years, 4 months ago (2013-07-22 13:45:31 UTC) #4
*** Submitted as https://code.google.com/p/go/source/detail?r=e503b72350b2 ***

[release-branch.go1.1] cmd/gc: fix issue with method wrappers not having escape
analysis run on them.

««« CL 10383048 / 58e15340e78f
cmd/gc: fix issue with method wrappers not having escape analysis run on them.

Escape analysis needs the right curfn value on a dclfunc node, otherwise it will
not analyze the function.
When generating method value wrappers, we forgot to set the curfn correctly.

Fixes issue 5753.

R=golang-dev, rsc
CC=golang-dev
https://codereview.appspot.com/10383048
»»»

Update issue 5928

R=golang-dev, dave
CC=golang-dev
https://codereview.appspot.com/11669043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b