Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(475)

Issue 11659043: Improve Openstack config deprecation warnings. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 3 months ago by wallyworld
Modified:
6 years, 3 months ago
Reviewers:
mp+176110, thumper, rog
Visibility:
Public.

Description

Improve Openstack config deprecation warnings. The warning messages when using the deprecated Openstack config items default-image-id and default-instance-type are improved. https://code.launchpad.net/~wallyworld/juju-core/better-openstack-config-deprecation-messages/+merge/176110 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 4

Patch Set 2 : Improve Openstack config deprecation warnings. #

Total comments: 12

Patch Set 3 : Improve Openstack config deprecation warnings. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+122 lines, -37 lines) Patch
A [revision details] View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M environs/openstack/config.go View 1 2 1 chunk +10 lines, -2 lines 0 comments Download
M environs/openstack/config_test.go View 1 2 9 chunks +110 lines, -35 lines 0 comments Download

Messages

Total messages: 7
wallyworld
Please take a look.
6 years, 3 months ago (2013-07-22 04:23:27 UTC) #1
thumper
Primary issue is should be using *testing.FakeHome to change HOME environment. https://codereview.appspot.com/11659043/diff/1/environs/openstack/config_test.go File environs/openstack/config_test.go (right): ...
6 years, 3 months ago (2013-07-22 04:43:02 UTC) #2
wallyworld
Please take a look. https://codereview.appspot.com/11659043/diff/1/environs/openstack/config_test.go File environs/openstack/config_test.go (right): https://codereview.appspot.com/11659043/diff/1/environs/openstack/config_test.go#newcode13 environs/openstack/config_test.go:13: "launchpad.net/loggo" On 2013/07/22 04:43:02, thumper ...
6 years, 3 months ago (2013-07-22 05:41:12 UTC) #3
rog
LGTM with a few thoughts regarding the testing. https://codereview.appspot.com/11659043/diff/6001/environs/openstack/config.go File environs/openstack/config.go (right): https://codereview.appspot.com/11659043/diff/6001/environs/openstack/config.go#newcode142 environs/openstack/config.go:142: "The ...
6 years, 3 months ago (2013-07-22 12:45:24 UTC) #4
wallyworld
Please take a look. https://codereview.appspot.com/11659043/diff/6001/environs/openstack/config.go File environs/openstack/config.go (right): https://codereview.appspot.com/11659043/diff/6001/environs/openstack/config.go#newcode142 environs/openstack/config.go:142: "The correct instance flavor is ...
6 years, 3 months ago (2013-07-23 05:03:47 UTC) #5
thumper
LGTM
6 years, 3 months ago (2013-07-23 05:08:57 UTC) #6
rog
6 years, 3 months ago (2013-07-23 07:35:39 UTC) #7
that's better, thanks. LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b