Update service menus and enable for inspector

Update service menus and enable for inspector

One of the last big issues remaining in the UX design to make the inspector usable was to make a disoverable way of creating relations.  Luca and Ant worked together to revamp the existing popup menu for the purpose.  This branch takes their design work and makes it work for both inspector and non-inspector uses.  In order to have it work well, I had to update some of the calculations that determined where the menu was drawn.

https://code.launchpad.net/~gary/juju-gui/styling-environment-menu/+merge/175973

(do not edit description out of merge proposal)

[gary.poster, 2013-07-20 01:25:54]

Please take a look.

[benji, 2013-07-22 12:47:04]

Looks great.

LGTM-ly, y'rs
Benji

https://codereview.appspot.com/11620043/diff/1/app/assets/images/icons/icon_n...
File app/assets/images/icons/icon_noshadow_destroy.png (right):

https://codereview.appspot.com/11620043/diff/1/app/assets/images/icons/icon_n...
app/assets/images/icons/icon_noshadow_destroy.png:6:
ð%—^éµß÷¾{w¼“@¹\î/Yl÷Øþ°}cëv:±Èw%
âg¼¼`»ƒÓ@(äݖ$â¥e­(ȕ
The fourth character on this line isn't right.

https://codereview.appspot.com/11620043/diff/1/lib/views/stylesheet.less
File lib/views/stylesheet.less (right):

https://codereview.appspot.com/11620043/diff/1/lib/views/stylesheet.less#newc...
lib/views/stylesheet.less:465: @background_color:
@enviroment-menu-background-color;
Yay for constants.

[bac, 2013-07-22 13:19:11]

LGTM with a few nits.  QA was fine.  Thanks!

https://codereview.appspot.com/11620043/diff/1/app/assets/images/icons/icon_n...
File app/assets/images/icons/icon_noshadow_destroy.png (right):

https://codereview.appspot.com/11620043/diff/1/app/assets/images/icons/icon_n...
app/assets/images/icons/icon_noshadow_destroy.png:6:
ð%—^éµß÷¾{w¼“@¹\î/Yl÷Øþ°}cëv:±Èw%
âg¼¼`»ƒÓ@(äݖ$â¥e­(ȕ
What is the result of 'ß÷¾'?

https://codereview.appspot.com/11620043/diff/1/app/assets/images/landscape_se...
File app/assets/images/landscape_security_menu.png (right):

https://codereview.appspot.com/11620043/diff/1/app/assets/images/landscape_se...
app/assets/images/landscape_security_menu.png:2: 
Dear Mr Rietveld, please don't show diffs for image files.

https://codereview.appspot.com/11620043/diff/1/app/views/topology/service.js
File app/views/topology/service.js (right):

https://codereview.appspot.com/11620043/diff/1/app/views/topology/service.js#...
app/views/topology/service.js:1196: z = topo.get('scale');
Using 'z' for scale seems wrong but it isn't your doing.

https://codereview.appspot.com/11620043/diff/1/app/views/topology/service.js#...
app/views/topology/service.js:1201: service_center = service.relativeCenter,
You were doing so good with your camelCase.  What happened?

https://codereview.appspot.com/11620043/diff/1/app/views/topology/service.js#...
app/views/topology/service.js:1225: (menuLeft ? service.w * z + 16 : -(cpWidth)
- 16) + tr[0]
What is magic about 16?  It would be more readable as a symbol.

https://codereview.appspot.com/11620043/diff/1/lib/views/stylesheet.less
File lib/views/stylesheet.less (right):

https://codereview.appspot.com/11620043/diff/1/lib/views/stylesheet.less#newc...
lib/views/stylesheet.less:31: @enviroment-menu-background-color: #ffffff;
persistent typos: environment

[gary.poster, 2013-07-22 19:57:01]

*** Submitted:

Update service menus and enable for inspector

One of the last big issues remaining in the UX design to make the inspector
usable was to make a disoverable way of creating relations.  Luca and Ant worked
together to revamp the existing popup menu for the purpose.  This branch takes
their design work and makes it work for both inspector and non-inspector uses. 
In order to have it work well, I had to update some of the calculations that
determined where the menu was drawn.

R=benji, bac
CC=
https://codereview.appspot.com/11620043