Rename second inspector to ViewletManager.

Rename second inspector to ViewletManager.

- Prevent having inspector.inspector. The inspector is the controller that
manages events and such. 
- The viewletManager is an object that helps control showing/hiding/cleaning
up viewlets in use.
- Update css classes and docs to describe the ViewletManager
- Update tests to use the updated class.
- Move the file to just viewlets as it's the source of managing viewlets and
contains the viewletbase class.
- update the module name and namespace to match the updated terminology.

https://code.launchpad.net/~rharding/juju-gui/viewlet-manager/+merge/175936

(do not edit description out of merge proposal)

[rharding, 2013-07-19 20:22:25]

Please take a look.

[rharding, 2013-07-20 00:19:37]

Please take a look.

[jeff.pihach, 2013-07-20 01:08:53]

Ahh this is going to make this code so much nicer to read :)

I haven't had a chance to QA yet but there are a few changes I'd like to see so
far that I think will make it even better.

https://codereview.appspot.com/11424045/diff/4001/app/modules-debug.js
File app/modules-debug.js (right):

https://codereview.appspot.com/11424045/diff/4001/app/modules-debug.js#newcod...
app/modules-debug.js:272: fullpath: '/juju-ui/views/viewlets.js'
I don't think that this name is representative of what's in the file. This
should probably be `viewlet-manager.js`instead

https://codereview.appspot.com/11424045/diff/4001/app/views/viewlets.js
File app/views/viewlets.js (right):

https://codereview.appspot.com/11424045/diff/4001/app/views/viewlets.js#newco...
app/views/viewlets.js:23: Adds the ViewletManaaer constructor class and viewlet
instantiable object
typo

https://codereview.appspot.com/11424045/diff/4001/app/views/viewlets.js#newco...
app/views/viewlets.js:40: ns.ViewletBase = {
This was intentionally made a private var to not allow external modifications.

https://codereview.appspot.com/11424045/diff/4001/app/views/viewlets.js#newco...
app/views/viewlets.js:61: '<div class="viewlet-manager-wrapper"
style="display:none"></div>',
I think that this should stay viewlet-wrapper as it doesn't wrap the manager,
it's a wrapper for the viewlet

https://codereview.appspot.com/11424045/diff/4001/app/views/viewlets.js#newco...
app/views/viewlets.js:126: render: function(model, managerAttrs) {
viewletManagerAttrs

https://codereview.appspot.com/11424045/diff/4001/app/views/viewlets.js#newco...
app/views/viewlets.js:213: ns.ViewletManager = new
Y.Base.create('viewlets-manager', Y.View, [], {
viewlet-manager

https://codereview.appspot.com/11424045/diff/4001/app/views/viewlets/charm-de...
File app/views/viewlets/charm-details.js (right):

https://codereview.appspot.com/11424045/diff/4001/app/views/viewlets/charm-de...
app/views/viewlets/charm-details.js:37: @param {Object} managerAttrs This comes
from the view-container
maybe viewletManagerAttrs

https://codereview.appspot.com/11424045/diff/4001/app/views/viewlets/unit-det...
File app/views/viewlets/unit-details.js (right):

https://codereview.appspot.com/11424045/diff/4001/app/views/viewlets/unit-det...
app/views/viewlets/unit-details.js:33: 'render': function(unit, managerAttrs) {
viewletManagerAttrs

https://codereview.appspot.com/11424045/diff/4001/docs/viewlets.rst
File docs/viewlets.rst (right):

https://codereview.appspot.com/11424045/diff/4001/docs/viewlets.rst#newcode133
docs/viewlets.rst:133: new Y.juju.ViewletManager({
Y.juju.viewlets.ViewletManager

[rharding, 2013-07-20 01:43:31]

On 2013/07/20 01:08:53, jeff.pihach wrote:
> Ahh this is going to make this code so much nicer to read :)
> 
> I haven't had a chance to QA yet but there are a few changes I'd like to see
so
> far that I think will make it even better.

Thanks so much for the prompt review. I've pulled trunk and made the updates
below. I appreciate you catching a couple of changes that I should not have
made.

Updated branch change is on the way. Go lbox go!

[rharding, 2013-07-20 01:44:58]

Please take a look.

[benji, 2013-07-22 13:30:31]

LGTM.  I spotted a couple of small things.

https://codereview.appspot.com/11424045/diff/14001/app/views/viewlet-manager.js
File app/views/viewlet-manager.js (right):

https://codereview.appspot.com/11424045/diff/14001/app/views/viewlet-manager....
app/views/viewlet-manager.js:61: '<div class="viewlet-wrapper"
style="display:none"></div>',
The @default comment doesn't appear to align with the code.

I question the usefulness of the @default comments, especially given that there
is nothing keeping them in sync with reality.

https://codereview.appspot.com/11424045/diff/14001/docs/viewlets.rst
File docs/viewlets.rst (right):

https://codereview.appspot.com/11424045/diff/14001/docs/viewlets.rst#newcode12
docs/viewlets.rst:12: The Viewlet Manager is a Y.View based class which acts as
a container and viewlet manager.
It would be nice to fix this long line.

https://codereview.appspot.com/11424045/diff/14001/docs/viewlets.rst#newcode107
docs/viewlets.rst:107: While a viewlet doesn't explicitly require the `Viewlet
Manager`_ it was designed
Long line.

[jeff.pihach, 2013-07-22 13:32:06]

Getting closer, I found a few typos and missed changes but this diff is missing
the appropriate changes to the *.less files. be sure to change those over too.

https://codereview.appspot.com/11424045/diff/14001/app/templates/ghost-config...
File app/templates/ghost-config-wrapper.handlebars (right):

https://codereview.appspot.com/11424045/diff/14001/app/templates/ghost-config...
app/templates/ghost-config-wrapper.handlebars:3: <div
class="view-container-navigation" style="clear: both;">
viewlet-manager-navigation

https://codereview.appspot.com/11424045/diff/14001/app/templates/ghost-config...
app/templates/ghost-config-wrapper.handlebars:24: <div
class="viewlet-container-footer"></div>
viewlet-manager-footer

https://codereview.appspot.com/11424045/diff/14001/app/templates/viewlet-mana...
File app/templates/viewlet-manager.handlebars (right):

https://codereview.appspot.com/11424045/diff/14001/app/templates/viewlet-mana...
app/templates/viewlet-manager.handlebars:1: <div
class="viewlet-managerr-wrapper">
typo

https://codereview.appspot.com/11424045/diff/14001/app/views/viewlet-manager.js
File app/views/viewlet-manager.js (right):

https://codereview.appspot.com/11424045/diff/14001/app/views/viewlet-manager....
app/views/viewlet-manager.js:57: @default '<div class="viewlet--manager-wrapper"
typo

[rharding, 2013-07-22 13:46:02]

Please take a look.

[rharding, 2013-07-22 14:07:30]

Please take a look.

[rharding, 2013-07-22 15:09:22]

Please take a look.

[rharding, 2013-07-22 15:58:35]

Please take a look.

[jeff.pihach, 2013-07-22 16:16:38]

LGTM 
QA OK

Thanks for putting in the time to make this code easier to read!

[rharding, 2013-07-22 16:29:30]

*** Submitted:

Rename second inspector to ViewletManager.

- Prevent having inspector.inspector. The inspector is the controller that
manages events and such. 
- The viewletManager is an object that helps control showing/hiding/cleaning
up viewlets in use.
- Update css classes and docs to describe the ViewletManager
- Update tests to use the updated class.
- Move the file to just viewlets as it's the source of managing viewlets and
contains the viewletbase class.
- update the module name and namespace to match the updated terminology.

R=jeff.pihach, benji
CC=
https://codereview.appspot.com/11424045