Issue 11398045: code review 11398045: go.tools/go/types: fix build: ignore self-test if it fails

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 11398045: code review 11398045: go.tools/go/types: fix build: ignore self-test if it fails (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 9 months ago by gri

Modified:
10 years, 9 months ago

Reviewers:

CC:
adonovan_google.com (tbr), golang-dev

Visibility:
Public.

Description

go.tools/go/types: fix build: ignore self-test if it fails

Patch Set 1 #

Patch Set 2 : diff -r 8f39782773ec https://code.google.com/p/go.tools #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -2 lines)			Patch
	M	go/types/self_test.go	View		1 chunk	+8 lines, -2 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

gri

Hello adonovan (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.tools

10 years, 9 months ago (2013-07-24 02:28:11 UTC) #1

gri

10 years, 9 months ago (2013-07-24 03:52:57 UTC) #2

*** Submitted as
https://code.google.com/p/go/source/detail?r=4e5f13bbb744&repo=tools ***

go.tools/go/types: fix build: ignore self-test if it fails

R=adonovan
CC=golang-dev
https://codereview.appspot.com/11398045

Expand All Messages | Collapse All Messages