Issue 11364043: code review 11364043: cmd/5c, cmd/6c, cmd/8c: record arg size for every call

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 11364043: code review 11364043: cmd/5c, cmd/6c, cmd/8c: record arg size for every call (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 9 months ago by rsc

Modified:
10 years, 9 months ago

Reviewers:
ken3

CC:
ken2, golang-dev

Visibility:
Public.

Description

cmd/5c, cmd/6c, cmd/8c: record arg size for every call

Patch Set 1 #

Patch Set 2 : diff -r 8b12d6f12155 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 7706f96f1c3b https://code.google.com/p/go/ #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+74 lines, -7 lines)			Patch
M	src/cmd/5c/cgen.c	View	1 2	2 chunks	+3 lines, -1 line	0 comments	Download
M	src/cmd/5c/gc.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/cmd/5c/sgen.c	View	1	1 chunk	+6 lines, -1 line	0 comments	Download
M	src/cmd/5c/txt.c	View	1	1 chunk	+9 lines, -0 lines	0 comments	Download
M	src/cmd/6c/cgen.c	View	1	3 chunks	+3 lines, -0 lines	0 comments	Download
M	src/cmd/6c/gc.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/cmd/6c/sgen.c	View	1	1 chunk	+10 lines, -3 lines	0 comments	Download
M	src/cmd/6c/txt.c	View	1	1 chunk	+9 lines, -0 lines	0 comments	Download
M	src/cmd/8c/cgen.c	View	1 2	3 chunks	+3 lines, -0 lines	0 comments	Download
M	src/cmd/8c/gc.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/cmd/8c/sgen.c	View	1	1 chunk	+7 lines, -2 lines	0 comments	Download
M	src/cmd/8c/txt.c	View	1	1 chunk	+9 lines, -0 lines	0 comments	Download
M	src/cmd/cc/cc.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/cmd/cc/pgen.c	View	1	1 chunk	+11 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello ken2 (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

10 years, 9 months ago (2013-07-16 20:24:41 UTC) #1

rsc

*** Submitted as https://code.google.com/p/go/source/detail?r=212b59f2a675 *** cmd/5c, cmd/6c, cmd/8c: record arg size for every call R=ken2 ...

10 years, 9 months ago (2013-07-16 20:24:46 UTC) #2

ken3

10 years, 9 months ago (2013-07-19 09:30:23 UTC) #3

Message was sent while issue was closed.

On 2013/07/16 20:24:46, rsc wrote:
> *** Submitted as https://code.google.com/p/go/source/detail?r=212b59f2a675 ***
> 
> cmd/5c, cmd/6c, cmd/8c: record arg size for every call
> 
> R=ken2
> CC=golang-dev
> https://codereview.appspot.com/11364043

lgtm

Expand All Messages | Collapse All Messages