Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2479)

Issue 11355046: code review 11355046: crypto: Correct s2k type constants. They are 0,1,3 acco...

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 9 months ago by adhintz
Modified:
10 years, 9 months ago
Reviewers:
agl1
CC:
agl1, evn, golang-dev
Visibility:
Public.

Description

crypto: Correct s2k type constants. They are 0,1,3 according to both the RFC: http://tools.ietf.org/html/rfc4880#section-3.7 And according to the gpg implementation: http://git.gnupg.org/cgi-bin/gitweb.cgi?p=gnupg.git&a=search&h=refs%2Fheads%2FSTABLE-BRANCH-2-0&st=grep&s=s2kmode

Patch Set 1 #

Patch Set 2 : diff -r 3b780a7120c9 https://code.google.com/p/go.crypto/ #

Patch Set 3 : diff -r 3b780a7120c9 https://code.google.com/p/go.crypto/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M openpgp/s2k/s2k.go View 1 1 chunk +2 lines, -2 lines 0 comments Download
M openpgp/s2k/s2k_test.go View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3
adhintz
Hello agl@golang.org (cc: evn@google.com, golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.crypto/
10 years, 9 months ago (2013-07-16 21:21:49 UTC) #1
agl1
LGTM Good catch, thanks! (Although anything that uses these modes should be shot :)
10 years, 9 months ago (2013-07-16 21:35:43 UTC) #2
agl1
10 years, 9 months ago (2013-07-16 21:40:07 UTC) #3
*** Submitted as
https://code.google.com/p/go/source/detail?r=e6ec41d36ff8&repo=crypto ***

crypto: Correct s2k type constants. They are 0,1,3 according to both the RFC:
http://tools.ietf.org/html/rfc4880#section-3.7
And according to the gpg implementation:
http://git.gnupg.org/cgi-bin/gitweb.cgi?p=gnupg.git&a=search&h=refs%2Fheads%2...

R=agl
CC=evn, golang-dev
https://codereview.appspot.com/11355046

Committer: Adam Langley <agl@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b