Have the lxc manager log dir be configurable.

Have the lxc manager log dir be configurable.

Since the local provider wants to store the log files
in a different location, the ContainerManager needs to
be configured with the location.

The default log location is still the same, but is now
able to be configured.

Also factored out the function for getting the IPv4 address
for a named interface.  The containers have "eth0" as their
network interface, so this is used to get the DNSName.

https://code.launchpad.net/~thumper/juju-core/lxc-identity/+merge/174922

Requires: https://code.launchpad.net/~thumper/juju-core/local-provider-machine-0/+merge/174921

(do not edit description out of merge proposal)

[thumper, 2013-07-16 05:16:27]

Please take a look.

[gz, 2013-07-16 10:18:34]

LGTM.

https://codereview.appspot.com/11327044/diff/1/environs/local/environprovider.go
File environs/local/environprovider.go (right):

https://codereview.appspot.com/11327044/diff/1/environs/local/environprovider...
environs/local/environprovider.go:124: // TODO(thumper): refactor this method
out of existance from the interface
Ian already tackled this to a large extent, see:

<https://codereview.appspot.com/11318043/>

[wallyworld, 2013-07-17 02:37:28]

LGTM

https://codereview.appspot.com/11327044/diff/1/environs/local/environprovider.go
File environs/local/environprovider.go (right):

https://codereview.appspot.com/11327044/diff/1/environs/local/environprovider...
environs/local/environprovider.go:124: // TODO(thumper): refactor this method
out of existance from the interface
On 2013/07/16 10:18:35, gz wrote:
> Ian already tackled this to a large extent, see:
> 
> <https://codereview.appspot.com/11318043/>

This method is gone in my unlanded work. I guess whoever gets to land first wins
the prize of not having to fix stuff up.