Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1273)

Issue 11282043: Sketch of future design

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 8 months ago by bcsaller
Modified:
10 years, 8 months ago
Reviewers:
mp+174765, matthew.scott, gary.poster
Visibility:
Public.

Description

Sketch of future design Incremental movement towards new design, includes service icons status bar https://code.launchpad.net/~bcsaller/juju-gui/future-design/+merge/174765 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 4

Patch Set 2 : Sketch of future design #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -147 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M app/assets/javascripts/d3.status.js View 2 chunks +23 lines, -20 lines 0 comments Download
M app/views/service.js View 2 chunks +14 lines, -9 lines 0 comments Download
M app/views/topology/service.js View 1 8 chunks +49 lines, -115 lines 0 comments Download
M lib/views/stylesheet.less View 1 chunk +2 lines, -1 line 0 comments Download
M test/test_environment_view.js View 3 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 4
bcsaller
Please take a look.
10 years, 8 months ago (2013-07-15 14:07:30 UTC) #1
gary.poster
LGTM cool! Thanks!
10 years, 8 months ago (2013-07-15 15:39:58 UTC) #2
matthew.scott
LGTM with a few comments https://codereview.appspot.com/11282043/diff/1/app/views/topology/service.js File app/views/topology/service.js (right): https://codereview.appspot.com/11282043/diff/1/app/views/topology/service.js#newcode376 app/views/topology/service.js:376: .classed('unit-count', true) I think ...
10 years, 8 months ago (2013-07-15 15:50:20 UTC) #3
bcsaller
10 years, 8 months ago (2013-07-15 15:58:56 UTC) #4
*** Submitted:

Sketch of future design

Incremental movement towards new design, includes

service icons
status bar

R=gary.poster, matthew.scott
CC=
https://codereview.appspot.com/11282043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b