Issue 11275045: Config can set logout button to Get Juju

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 11275045: Config can set logout button to Get Juju

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 9 months ago by jeff.pihach

Modified:
10 years, 9 months ago

Reviewers:
j.c.sackett, mp+174829, gary.poster

Visibility:
Public.

Description

Config can set logout button to Get Juju https://code.launchpad.net/~hatch/juju-gui/change-logout/+merge/174829 (do not edit description out of merge proposal)

Patch Set 2 : Config can set logout button to Get Juju #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+49 lines, -9 lines)			Patch
A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	app/app.js	View	1	1 chunk	+5 lines, -2 lines	0 comments	Download
M	app/config-debug.js	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	app/config-prod.js	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	app/index.html	View		4 chunks	+19 lines, -4 lines	0 comments	Download
M	test/test_startup.js.bottom	View		1 chunk	+16 lines, -0 lines	0 comments	Download
M	test/test_startup.js.top	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

gary.poster

Code LGTM, with Jon doing qa. https://codereview.appspot.com/11275045/diff/1/app/app.js File app/app.js (right): https://codereview.appspot.com/11275045/diff/1/app/app.js#newcode579 app/app.js:579: if (!window.juju_config.showJujuButton) { ...

10 years, 9 months ago (2013-07-15 17:57:38 UTC) #2

j.c.sackett

LGTM with one minor fix and one code fix. https://codereview.appspot.com/11275045/diff/1/app/app.js File app/app.js (right): https://codereview.appspot.com/11275045/diff/1/app/app.js#newcode578 app/app.js:578: ...

10 years, 9 months ago (2013-07-15 18:06:05 UTC) #3

jeff.pihach

Thanks for the reviews - fixes made! https://codereview.appspot.com/11275045/diff/1/app/app.js File app/app.js (right): https://codereview.appspot.com/11275045/diff/1/app/app.js#newcode579 app/app.js:579: if (!window.juju_config.showJujuButton) ...

10 years, 9 months ago (2013-07-15 18:14:12 UTC) #4

jeff.pihach

10 years, 9 months ago (2013-07-15 18:20:16 UTC) #5

*** Submitted:

Config can set logout button to Get Juju

R=gary.poster, j.c.sackett
CC=
https://codereview.appspot.com/11275045

Expand All Messages | Collapse All Messages