Guard around missing service config object

Guard around missing service config object

If a services charm was missing config options it could prevent the rendering
of the inspector by raising an exception.

https://code.launchpad.net/~bcsaller/juju-gui/service-options-viewlet/+merge/174496

(do not edit description out of merge proposal)

[bcsaller, 2013-07-12 20:21:27]

Please take a look.

[gary.poster, 2013-07-12 21:08:24]

LGTM with fix, and consideration of suggestion.  Would really prefer to see a
test of the setting of description and type actually working too.

Thank you!

https://codereview.appspot.com/11228043/diff/1/app/views/service.js
File app/views/service.js (right):

https://codereview.appspot.com/11228043/diff/1/app/views/service.js#newcode1600
app/views/service.js:1600: settings.type = option.type;
setting, not settings!  Makes me worried about tests.

https://codereview.appspot.com/11228043/diff/1/app/views/service.js#newcode1601
app/views/service.js:1601: }
Fine.  I'd replace the above six lines with the following equivalent myself
(ripping out the conditionals because option.description and option.type will be
undefined, which can be obtained and set without errors).  Your call.

setting.description = option.description;
setting.type = option.type;

[benjamin.saller, 2013-07-12 21:44:55]

Thanks, changes made

https://codereview.appspot.com/11228043/diff/1/app/views/service.js
File app/views/service.js (right):

https://codereview.appspot.com/11228043/diff/1/app/views/service.js#newcode1600
app/views/service.js:1600: settings.type = option.type;
On 2013/07/12 21:08:25, gary.poster wrote:
> setting, not settings!  Makes me worried about tests.

Nice catch. Yeah, I don't test all the combos of missing attrs here.

https://codereview.appspot.com/11228043/diff/1/app/views/service.js#newcode1601
app/views/service.js:1601: }
On 2013/07/12 21:08:25, gary.poster wrote:
> Fine.  I'd replace the above six lines with the following equivalent myself
> (ripping out the conditionals because option.description and option.type will
be
> undefined, which can be obtained and set without errors).  Your call.
> 
> setting.description = option.description;
> setting.type = option.type;

Agreed, done

[bcsaller, 2013-07-13 00:13:10]

*** Submitted:

Guard around missing service config object

If a services charm was missing config options it could prevent the rendering
of the inspector by raising an exception.

R=gary.poster, benjamin.saller
CC=
https://codereview.appspot.com/11228043