Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(403)

Issue 112270043: code review 112270043: ogle/server: provide type-aware printer for DWARF-typed... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 4 months ago by r
Modified:
7 years, 4 months ago
Reviewers:
nigeltao
CC:
nigeltao
Visibility:
Public.

Description

ogle/server: provide type-aware printer for DWARF-typed objects

Patch Set 1 #

Patch Set 2 : diff -r 836b304af90d https://code.google.com/p/ogle #

Patch Set 3 : diff -r 836b304af90d https://code.google.com/p/ogle #

Total comments: 28

Patch Set 4 : diff -r 836b304af90d https://code.google.com/p/ogle #

Unified diffs Side-by-side diffs Delta from patch set Stats (+461 lines, -48 lines) Patch
M arch/arch.go View 1 chunk +21 lines, -0 lines 0 comments Download
M debug/dwarf/symbol.go View 1 2 3 7 chunks +31 lines, -18 lines 0 comments Download
M program/program.go View 2 chunks +5 lines, -2 lines 0 comments Download
M program/server/dwarf.go View 2 chunks +3 lines, -3 lines 0 comments Download
A program/server/print.go View 1 2 3 1 chunk +373 lines, -0 lines 0 comments Download
M program/server/server.go View 7 chunks +28 lines, -25 lines 0 comments Download

Messages

Total messages: 6
r
Hello nigeltao, I'd like you to review this change to https://code.google.com/p/ogle
7 years, 4 months ago (2014-07-14 19:21:54 UTC) #1
r
Hello nigeltao@golang.org, Please take another look.
7 years, 4 months ago (2014-07-14 20:49:08 UTC) #2
nigeltao
https://codereview.appspot.com/112270043/diff/40001/debug/dwarf/symbol.go File debug/dwarf/symbol.go (right): https://codereview.appspot.com/112270043/diff/40001/debug/dwarf/symbol.go#newcode67 debug/dwarf/symbol.go:67: return nil, fmt.Errorf("symbol %q not found", name) s/symbol/entry/ ? ...
7 years, 4 months ago (2014-07-15 04:14:41 UTC) #3
nigeltao
LGTM.
7 years, 4 months ago (2014-07-15 04:20:34 UTC) #4
r
https://codereview.appspot.com/112270043/diff/40001/debug/dwarf/symbol.go File debug/dwarf/symbol.go (right): https://codereview.appspot.com/112270043/diff/40001/debug/dwarf/symbol.go#newcode67 debug/dwarf/symbol.go:67: return nil, fmt.Errorf("symbol %q not found", name) On 2014/07/15 ...
7 years, 4 months ago (2014-07-15 04:56:51 UTC) #5
r
7 years, 4 months ago (2014-07-15 04:56:53 UTC) #6
*** Submitted as https://code.google.com/p/ogle/source/detail?r=fe930b89c877 ***

ogle/server: provide type-aware printer for DWARF-typed objects

LGTM=nigeltao
R=nigeltao
https://codereview.appspot.com/112270043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b