Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(749)

Issue 110240044: Doc: NR Pitches.itely - Clef - updated snippets and text (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 10 months ago by pkx166h
Modified:
9 years, 7 months ago
Reviewers:
Keith
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Issue 3976 Added 2 new snippets: 1 snippet added to NR 1 snippet added just to Snippets Modified 1 existing snippet: This was already (and still is) included in the NR Deleted 2 snippets (and incorporated them in the main text in @lilyponds) Added new @lilypond example that was originally described (but not show)n in the 'Tweaking Clef Properties' snippet to show how to remove the clef glyph from the end of a line. As this 'tweak' is relatively simple (a single \set and \unset) and more than likely to be used (IMHO) by the general user than the listed items in the snippet, I thought it better to be in the NR than another example in either an already long snippet or by creating yet another snippet. Some minor linelength formatting as per CG.

Patch Set 1 #

Patch Set 2 : WIth Pierre's suggestion and some texidoc edits #

Patch Set 3 : Used correct 'comment' symbol in Scheme #

Total comments: 4

Patch Set 4 : Rebased with master and made some adjustments to the description. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+142 lines, -114 lines) Patch
M Documentation/notation/pitches.itely View 1 2 3 5 chunks +61 lines, -10 lines 0 comments Download
D Documentation/snippets/forcing-a-clef-symbol-to-be-displayed.ly View 1 2 3 1 chunk +0 lines, -32 lines 0 comments Download
D Documentation/snippets/keep-change-clefs-full-sized.ly View 1 2 3 1 chunk +0 lines, -37 lines 0 comments Download
A Documentation/snippets/new/creating-custom-key-signatures.ly View 1 2 3 1 chunk +36 lines, -0 lines 0 comments Download
A Documentation/snippets/new/modifying-the-ottava-spanner-slope.ly View 1 2 1 chunk +31 lines, -0 lines 0 comments Download
A + Documentation/snippets/new/tweaking-clef-properties.ly View 1 2 3 2 chunks +14 lines, -35 lines 0 comments Download

Messages

Total messages: 9
pkx166h
WIth Pierre's suggestion and some texidoc edits
9 years, 9 months ago (2014-06-27 23:13:34 UTC) #1
pkx166h
Used correct 'comment' symbol in Scheme
9 years, 9 months ago (2014-06-28 10:33:14 UTC) #2
Keith
Is it worth making the Notation Reference longer? https://codereview.appspot.com/110240044/diff/40001/Documentation/notation/pitches.itely File Documentation/notation/pitches.itely (right): https://codereview.appspot.com/110240044/diff/40001/Documentation/notation/pitches.itely#newcode1325 Documentation/notation/pitches.itely:1325: \override ...
9 years, 9 months ago (2014-06-29 03:17:00 UTC) #3
pkx166h
> Is it worth making the Notation Reference longer? What do you suggest? https://codereview.appspot.com/110240044/diff/40001/Documentation/notation/pitches.itely File ...
9 years, 9 months ago (2014-06-30 21:40:17 UTC) #4
Keith
On Mon, 30 Jun 2014 14:40:17 -0700, <pkx166h@gmail.com> wrote: >> Is it worth making the ...
9 years, 9 months ago (2014-07-01 06:56:42 UTC) #5
pkx166h
On 2014/07/01 06:56:42, Keith wrote: > On Mon, 30 Jun 2014 14:40:17 -0700, <mailto:pkx166h@gmail.com> wrote: ...
9 years, 9 months ago (2014-07-01 07:34:26 UTC) #6
pkx166h
rebase of patch (still work to do)
9 years, 7 months ago (2014-08-27 11:50:58 UTC) #7
pkx166h
Rebased with master and made some adjustments to the description.
9 years, 7 months ago (2014-08-29 17:53:09 UTC) #8
pkx166h
9 years, 7 months ago (2014-09-12 08:23:24 UTC) #9
author	James Lowe <pkx166h@gmail.com>	
	Thu, 26 Jun 2014 21:37:04 +0000 (22:37 +0100)
committer	James Lowe <pkx166h@gmail.com>	
	Fri, 12 Sep 2014 08:20:11 +0000 (09:20 +0100)
commit	a1c9c3d285a2f3e59cf79a375b67cfb58ceca7ba
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b