Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(128)

Issue 10935043: code review 10935043: run.bash: enlarge timeout of runtime tests (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 9 months ago by minux1
Modified:
10 years, 8 months ago
Reviewers:
rsc
CC:
golang-dev, peterGo, rsc
Visibility:
Public.

Description

run.bash: enlarge timeout of runtime tests Recently addition to runtime test makes it take very close to 720s of timeout limit on the netbsd-arm-qemu builder.

Patch Set 1 #

Patch Set 2 : diff -r bb98e4c9b6b3 https://code.google.com/p/go/ #

Patch Set 3 : diff -r bb98e4c9b6b3 https://code.google.com/p/go/ #

Total comments: 1

Patch Set 4 : diff -r 14ded0061c96 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/run.bash View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6
minux1
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/
10 years, 9 months ago (2013-07-04 08:59:23 UTC) #1
peterGo
https://codereview.appspot.com/10935043/diff/6001/src/run.bash File src/run.bash (right): https://codereview.appspot.com/10935043/diff/6001/src/run.bash#newcode52 src/run.bash:52: GOMAXPROCS=2 go test runtime -short -timeout=$(expr 300 \* $timeout_scale)s ...
10 years, 8 months ago (2013-07-05 12:00:11 UTC) #2
minux1
On Friday, July 5, 2013, peter wrote: > > https://codereview.appspot.**com/10935043/diff/6001/src/**run.bash<https://codereview.appspot.com/10935043/diff/6001/src/run.bash> > File src/run.bash (right): > ...
10 years, 8 months ago (2013-07-06 14:54:08 UTC) #3
minux1
On Fri, Jul 5, 2013 at 8:00 PM, <go.peter.90@gmail.com> wrote: > Even on an Intel ...
10 years, 8 months ago (2013-07-07 21:59:10 UTC) #4
rsc
LGTM I thought I LGTM'ed this already. Maybe it was a different timeout. It's getting ...
10 years, 8 months ago (2013-07-12 11:54:45 UTC) #5
minux1
10 years, 8 months ago (2013-07-12 18:00:21 UTC) #6
*** Submitted as https://code.google.com/p/go/source/detail?r=28420f79988f ***

run.bash: enlarge timeout of runtime tests
Recently addition to runtime test makes it take very close to 720s
of timeout limit on the netbsd-arm-qemu builder.

R=golang-dev, go.peter.90, rsc
CC=golang-dev
https://codereview.appspot.com/10935043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b