Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(284)

Issue 10847043: code review 10847043: go.crypto/openpgp: don't select expired keys. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 9 months ago by agl1
Modified:
10 years, 8 months ago
Reviewers:
bradfitz
CC:
bradfitz, golang-dev
Visibility:
Public.

Description

go.crypto/openpgp: don't select expired keys. When selecting keys for encryption, don't select keys that have expired. Fixes issue 5808.

Patch Set 1 : diff -r 1f2453f1ed54 https://code.google.com/p/go.crypto/ #

Patch Set 2 : diff -r 1f2453f1ed54 https://code.google.com/p/go.crypto/ #

Total comments: 2

Patch Set 3 : diff -r 6ad91f44b054 https://code.google.com/p/go.crypto/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -38 lines) Patch
M openpgp/keys.go View 2 chunks +42 lines, -32 lines 0 comments Download
A openpgp/keys_test.go View 1 chunk +41 lines, -0 lines 0 comments Download
M openpgp/packet/signature.go View 1 2 1 chunk +10 lines, -0 lines 0 comments Download
M openpgp/write.go View 2 chunks +9 lines, -4 lines 0 comments Download
M openpgp/write_test.go View 3 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 8
agl1
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.crypto/
10 years, 9 months ago (2013-07-01 21:55:06 UTC) #1
r
fixes issue 5808?
10 years, 9 months ago (2013-07-01 23:51:01 UTC) #2
agl1
On 2013/07/01 23:51:01, r wrote: > fixes issue 5808? Yes, good point. Updated.
10 years, 9 months ago (2013-07-02 17:10:01 UTC) #3
agl1
On Tue, Jul 2, 2013 at 1:10 PM, <agl@golang.org> wrote: > Yes, good point. Updated. ...
10 years, 8 months ago (2013-07-12 15:58:51 UTC) #4
rsc
R=bradfitz
10 years, 8 months ago (2013-07-12 16:14:07 UTC) #5
bradfitz
LGTM https://codereview.appspot.com/10847043/diff/5006/openpgp/packet/signature.go File openpgp/packet/signature.go (right): https://codereview.appspot.com/10847043/diff/5006/openpgp/packet/signature.go#newcode386 openpgp/packet/signature.go:386: // KeyExpired returns true iff sig is a ...
10 years, 8 months ago (2013-07-17 00:32:49 UTC) #6
agl1
*** Submitted as https://code.google.com/p/go/source/detail?r=c0932d3462e8&repo=crypto *** go.crypto/openpgp: don't select expired keys. When selecting keys for encryption, ...
10 years, 8 months ago (2013-07-22 22:23:36 UTC) #7
agl1
10 years, 8 months ago (2013-07-22 22:23:45 UTC) #8
Message was sent while issue was closed.
https://codereview.appspot.com/10847043/diff/5006/openpgp/packet/signature.go
File openpgp/packet/signature.go (right):

https://codereview.appspot.com/10847043/diff/5006/openpgp/packet/signature.go...
openpgp/packet/signature.go:386: // KeyExpired returns true iff sig is a
self-signature of a key that has
On 2013/07/17 00:32:50, bradfitz wrote:
> Go style: s/true iff/whether/

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b