Issue 10821043: code review 10821043: image/gif: close the lzw.Reader we create.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 10821043: code review 10821043: image/gif: close the lzw.Reader we create. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 9 months ago by nigeltao

Modified:
10 years, 9 months ago

Reviewers:
dsymonds, adg

CC:
r, dsymonds, adg, andybons, golang-dev

Visibility:
Public.

Description

image/gif: close the lzw.Reader we create. The lzw.NewReader doc comment says, "It is the caller's responsibility to call Close on the ReadCloser when finished reading." Thanks to Andrew Bonventre for noticing this.

Patch Set 1 #

Patch Set 2 : diff -r fc3ae28f77f9 https://code.google.com/p/go/ #

Patch Set 3 : diff -r fc3ae28f77f9 https://code.google.com/p/go/ #

Patch Set 4 : diff -r 2bbca155a87f https://code.google.com/p/go/ #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	src/pkg/image/gif/reader.go	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

nigeltao

Hello r@golang.org (cc: andybons@gmail.com, golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

10 years, 9 months ago (2013-07-01 06:29:33 UTC) #1

nigeltao

10 years, 9 months ago (2013-07-05 00:12:27 UTC) #4

*** Submitted as https://code.google.com/p/go/source/detail?r=c95593ece13a ***

image/gif: close the lzw.Reader we create.

The lzw.NewReader doc comment says, "It is the caller's responsibility
to call Close on the ReadCloser when finished reading."

Thanks to Andrew Bonventre for noticing this.

R=r, dsymonds, adg
CC=andybons, golang-dev
https://codereview.appspot.com/10821043

Expand All Messages | Collapse All Messages