Changes.tely updated - 2.19.x up to June 2014

Changes.tely updated - 2.19.x up to June 2014

Since Feb 17th 2014.

Added Tracker issues
2752, 3950, 3954, 3934, 3937, 3915, 3913 and 3860

[dak, 2014-06-22 15:36:45]

Thanks for scraping the reports for this!

https://codereview.appspot.com/108130043/diff/1/Documentation/changes.tely
File Documentation/changes.tely (right):

https://codereview.appspot.com/108130043/diff/1/Documentation/changes.tely#ne...
Documentation/changes.tely:68: Improved the automatic @q{x-extent} placement of
Accidentals.
It's X-extent, and we don't list bug fixes.

https://codereview.appspot.com/108130043/diff/1/Documentation/changes.tely#ne...
Documentation/changes.tely:74: @code{\compundMeter} no longer changes the
@code{TimeSignature.stencil}
compoundMeter, and it's actually another bug fix.

https://codereview.appspot.com/108130043/diff/1/Documentation/changes.tely#ne...
Documentation/changes.tely:78: Improved the legibility of many types of error
messages that can be
That's an actual feature but I don't think it makes sense to describe it in
Changes as it is an incremental benefit but not something that will make people
create scores they could not before.

https://codereview.appspot.com/108130043/diff/1/Documentation/changes.tely#ne...
Documentation/changes.tely:83: without it creating an extra staff.
Another bug fix.  Totally longstanding, yes.  But hard to qualify in terms of
usability.

I actually would be hard put to create a sensible Changes entry if we were to
fix issue 34 in spite of it being a real nuisance.

https://codereview.appspot.com/108130043/diff/1/Documentation/changes.tely#ne...
Documentation/changes.tely:86: It is now possible to color and/or parenthesize
single dots in fret
Now *that's* a worthwhile entry.  Would it be possible to create a visual
example by consulting the regtest?

https://codereview.appspot.com/108130043/diff/1/Documentation/changes.tely#ne...
Documentation/changes.tely:90: Two new properties have been added for use in
fret-diagram-details;
Another case worth an example.

https://codereview.appspot.com/108130043/diff/1/Documentation/changes.tely#ne...
Documentation/changes.tely:96: A new command @code{\justify-line} has been
added.  Similar to the
Not sure whether it makes sense to add an example here.  Could be if one can
think of a nice snappy one.

[pkx166h, 2014-06-28 16:22:03]

David K's corrections and included some examples for two new features

[pkx166h, 2014-06-28 16:26:16]

Thanks

https://codereview.appspot.com/108130043/diff/1/Documentation/changes.tely
File Documentation/changes.tely (right):

https://codereview.appspot.com/108130043/diff/1/Documentation/changes.tely#ne...
Documentation/changes.tely:68: Improved the automatic @q{x-extent} placement of
Accidentals.
On 2014/06/22 15:36:45, dak wrote:
> It's X-extent, and we don't list bug fixes.

Removed.

https://codereview.appspot.com/108130043/diff/1/Documentation/changes.tely#ne...
Documentation/changes.tely:74: @code{\compundMeter} no longer changes the
@code{TimeSignature.stencil}
On 2014/06/22 15:36:45, dak wrote:
> compoundMeter, and it's actually another bug fix

Removed

https://codereview.appspot.com/108130043/diff/1/Documentation/changes.tely#ne...
Documentation/changes.tely:78: Improved the legibility of many types of error
messages that can be
On 2014/06/22 15:36:44, dak wrote:
> That's an actual feature but I don't think it makes sense to describe it in
> Changes as it is an incremental benefit but not something that will make
people
> create scores they could not before.

Removed.

https://codereview.appspot.com/108130043/diff/1/Documentation/changes.tely#ne...
Documentation/changes.tely:83: without it creating an extra staff.
On 2014/06/22 15:36:45, dak wrote:
> Another bug fix.  Totally longstanding, yes.  But hard to qualify in terms of
> usability.
> 
> I actually would be hard put to create a sensible Changes entry if we were to
> fix issue 34 in spite of it being a real nuisance.

Removed.

https://codereview.appspot.com/108130043/diff/1/Documentation/changes.tely#ne...
Documentation/changes.tely:86: It is now possible to color and/or parenthesize
single dots in fret
On 2014/06/22 15:36:45, dak wrote:
> Now *that's* a worthwhile entry.  Would it be possible to create a visual
> example by consulting the regtest?

Done.

https://codereview.appspot.com/108130043/diff/1/Documentation/changes.tely#ne...
Documentation/changes.tely:90: Two new properties have been added for use in
fret-diagram-details;
On 2014/06/22 15:36:45, dak wrote:
> Another case worth an example.

Not done yet. Am waiting on some extra information (fret diagrams are not
something I am familiar with in terms of music notation). I can add one in
another patch if I don't get one in time.

https://codereview.appspot.com/108130043/diff/1/Documentation/changes.tely#ne...
Documentation/changes.tely:96: A new command @code{\justify-line} has been
added.  Similar to the
On 2014/06/22 15:36:45, dak wrote:
> Not sure whether it makes sense to add an example here.  Could be if one can
> think of a nice snappy one.

Hopefully what I have done illustrates this concisely - David N gave me some
pointers. I used \typewriter as this is a mono spaced font which helps make the
point.

[pkx166h, 2014-06-28 17:28:41]

Uploaded to wrong tracker

[pkx166h, 2014-06-28 19:10:36]

Fix TexInfo markup that breaks make

[pkx166h, 2014-06-28 19:48:22]

Added another @lilypond example for fretted diagrams

[pkx166h, 2014-06-28 19:50:41]

Now added an example for the horizontal and parenthesis padding for fretted
diagrams

https://codereview.appspot.com/108130043/diff/1/Documentation/changes.tely
File Documentation/changes.tely (right):

https://codereview.appspot.com/108130043/diff/1/Documentation/changes.tely#ne...
Documentation/changes.tely:90: Two new properties have been added for use in
fret-diagram-details;
On 2014/06/28 16:26:16, J_lowe wrote:
> On 2014/06/22 15:36:45, dak wrote:
> > Another case worth an example.
> 
> Not done yet. Am waiting on some extra information (fret diagrams are not
> something I am familiar with in terms of music notation). I can add one in
> another patch if I don't get one in time.

Now added an example for this new feature

[Keith, 2014-06-29 03:20:16]

https://codereview.appspot.com/108130043/diff/70001/Documentation/changes.tely
File Documentation/changes.tely (right):

https://codereview.appspot.com/108130043/diff/70001/Documentation/changes.tel...
Documentation/changes.tely:145: pair is always consistant.  The following
examples illustrate this by
For some reason, inconsistently with the original French, English spells it
'consistent'

[david.nalesnik, 2014-06-29 12:52:36]

https://codereview.appspot.com/108130043/diff/70001/Documentation/changes.tely
File Documentation/changes.tely (right):

https://codereview.appspot.com/108130043/diff/70001/Documentation/changes.tel...
Documentation/changes.tely:141: A new markup command @code{\justify-line} has
been added.  Similar to
This should be a complete sentence. (Sorry--looks like that was my doing.) 
Perhaps something like:

It is similar to the @code{\fill-line} markup command.  Each @emph{word},
however, is spaced using . . .

[Now, whether the comma should belong to the @emph, I don't know.  I was told by
a fussy professor that "however" shouldn't begin a sentence.]

[pkx166h, 2014-06-30 21:53:36]

David N and Keith O's comments

[pkx166h, 2014-06-30 22:00:15]

Thanks

https://codereview.appspot.com/108130043/diff/70001/Documentation/changes.tely
File Documentation/changes.tely (right):

https://codereview.appspot.com/108130043/diff/70001/Documentation/changes.tel...
Documentation/changes.tely:141: A new markup command @code{\justify-line} has
been added.  Similar to
On 2014/06/29 12:52:36, david.nalesnik wrote:
> This should be a complete sentence. (Sorry--looks like that was my doing.) 
> Perhaps something like:
> 
> It is similar to the @code{\fill-line} markup command.  Each @emph{word},
> however, is spaced using . . .

Too 'bitty', but I've included the definite article to start the Sentence
(starting every sentence with an article does get tedious to read).
> 
> [Now, whether the comma should belong to the @emph, I don't know.  I was told
by
> a fussy professor that "however" shouldn't begin a sentence.]

Yes and I bet he said 'And', 'So' and 'Because' shouldn't either right?

However, I think you'll be fine with what I done here.

;)

https://codereview.appspot.com/108130043/diff/70001/Documentation/changes.tel...
Documentation/changes.tely:145: pair is always consistant.  The following
examples illustrate this by
On 2014/06/29 03:20:15, Keith wrote:
> For some reason, inconsistently with the original French, English spells it
> 'consistent'

Done.

[david.nalesnik, 2014-07-01 11:48:24]

On 2014/06/30 22:00:15, J_lowe wrote:
> Thanks
> 
> https://codereview.appspot.com/108130043/diff/70001/Documentation/changes.tely
> File Documentation/changes.tely (right):
> 
>
https://codereview.appspot.com/108130043/diff/70001/Documentation/changes.tel...
> Documentation/changes.tely:141: A new markup command @code{\justify-line} has
> been added.  Similar to
> On 2014/06/29 12:52:36, david.nalesnik wrote:
> > This should be a complete sentence. (Sorry--looks like that was my doing.) 
> > Perhaps something like:
> > 
> > It is similar to the @code{\fill-line} markup command.  Each @emph{word},
> > however, is spaced using . . .
> 
> Too 'bitty', but I've included the definite article to start the Sentence
> (starting every sentence with an article does get tedious to read).
> > 
> > [Now, whether the comma should belong to the @emph, I don't know.  I was
told
> by
> > a fussy professor that "however" shouldn't begin a sentence.]
> 
> Yes and I bet he said 'And', 'So' and 'Because' shouldn't either right?

Sure, but I'd never heard that "however" needed to be used "postpositively,"
which was how he put it.  It does sound better that way, I think.

> 
> However, I think you'll be fine with what I done here.
> 
> ;)

Thanks--works for me.

[Mark Polesky, 2014-07-04 07:17:26]

https://codereview.appspot.com/108130043/diff/90001/Documentation/changes.tely
File Documentation/changes.tely (right):

https://codereview.appspot.com/108130043/diff/90001/Documentation/changes.tel...
Documentation/changes.tely:68: Add support for @code{\once}@code{\unset}
@code{\once@tie{}\unset}

https://codereview.appspot.com/108130043/diff/90001/Documentation/changes.tel...
Documentation/changes.tely:71: It is now possible to individually color both the
dots and parenthesis
parentheses

https://codereview.appspot.com/108130043/diff/90001/Documentation/changes.tel...
Documentation/changes.tely:111: space between the dot and the parenthesis
surrounding it.
parentheses

https://codereview.appspot.com/108130043/diff/90001/Documentation/changes.tel...
Documentation/changes.tely:151: \fill-line {Ooooo oOooo ooOoo oooOo ooooO}
I prefer this:
\fill-line \underline {"↓    " " ↓   " "  ↓  " "   ↓ " "    ↓"}

https://codereview.appspot.com/108130043/diff/90001/Documentation/changes.tel...
Documentation/changes.tely:156: \justify-line {Ooooo Ooooo Ooooo Ooooo Ooooo}
I prefer this:
\justify-line \underline {"↓    " "↓    " "↓    " "↓    " "↓    "}

[Keith, 2014-07-05 17:46:15]

https://codereview.appspot.com/108130043/diff/90001/Documentation/changes.tely
File Documentation/changes.tely (right):

https://codereview.appspot.com/108130043/diff/90001/Documentation/changes.tel...
Documentation/changes.tely:143: spaced using only its @emph{left-edge} as
reference point.  This ensures
David K was talking about making fill-line use reference points where your
capital 'O's are placed, but (correctly) didn't do that.  Reference points are
not a helpful concept for explaining two functions.

As Dan suggested, different-length words make it clear.
\fill-line sets in columns; \justify-line balances whitespace

\paper { #(set-paper-size "a6" ) } 
\markup \fill-line {ooo ooo ooo ooo}
\markup \fill-line {ooooooooo oooooooo oo ooo}
\markup \justify-line {vvv vvv vvv vvv}
\markup \justify-line {vvvvvvvvv vvvvvvvv vv vvv}

[pkx166h, 2014-07-08 19:55:20]

Thanks to Keith O and Mark P for their comments

[pkx166h, 2014-07-09 05:31:18]

Applied to Master

[pkx166h, 2014-07-09 19:02:16]

Rebased with current master

[pkx166h, 2014-07-09 21:42:41]

https://codereview.appspot.com/108130043/diff/90001/Documentation/changes.tely
File Documentation/changes.tely (right):

https://codereview.appspot.com/108130043/diff/90001/Documentation/changes.tel...
Documentation/changes.tely:68: Add support for @code{\once}@code{\unset}
On 2014/07/04 07:17:26, Mark Polesky wrote:
> @code{\once@tie{}\unset}
OK

https://codereview.appspot.com/108130043/diff/90001/Documentation/changes.tel...
Documentation/changes.tely:71: It is now possible to individually color both the
dots and parenthesis
On 2014/07/04 07:17:26, Mark Polesky wrote:
> parentheses

Done.

https://codereview.appspot.com/108130043/diff/90001/Documentation/changes.tel...
Documentation/changes.tely:111: space between the dot and the parenthesis
surrounding it.
On 2014/07/04 07:17:26, Mark Polesky wrote:
> parentheses

Done.

https://codereview.appspot.com/108130043/diff/90001/Documentation/changes.tel...
Documentation/changes.tely:143: spaced using only its @emph{left-edge} as
reference point.  This ensures
On 2014/07/05 17:46:15, Keith wrote:
> David K was talking about making fill-line use reference points where your
> capital 'O's are placed, but (correctly) didn't do that.  Reference points are
> not a helpful concept for explaining two functions.
> 
> As Dan suggested, different-length words make it clear.
> \fill-line sets in columns; \justify-line balances whitespace
> 
> \paper { #(set-paper-size "a6" ) } 
> \markup \fill-line {ooo ooo ooo ooo}
> \markup \fill-line {ooooooooo oooooooo oo ooo}
> \markup \justify-line {vvv vvv vvv vvv}
> \markup \justify-line {vvvvvvvvv vvvvvvvv vv vvv}

Thanks. I've taken your suggestions and remade the example. I didn't see the
point of using different charachters for each command so stuck
with the 'oooo' and included the paper size in the lilypond-book 
settings to keep the example cleaner.

https://codereview.appspot.com/108130043/diff/90001/Documentation/changes.tel...
Documentation/changes.tely:151: \fill-line {Ooooo oOooo ooOoo oooOo ooooO}
On 2014/07/04 07:17:26, Mark Polesky wrote:
> I prefer this:
> \fill-line \underline {"↓    " " ↓   " "  ↓  " "   ↓ " "    ↓"}

See Keith's comment above.

https://codereview.appspot.com/108130043/diff/90001/Documentation/changes.tel...
Documentation/changes.tely:156: \justify-line {Ooooo Ooooo Ooooo Ooooo Ooooo}
On 2014/07/04 07:17:26, Mark Polesky wrote:
> I prefer this:
> \justify-line \underline {"↓    " "↓    " "↓    " "↓    " "↓    "}

See Keith's comment above

[pkx166h, 2014-07-15 16:39:10]

author	James Lowe <pkx166h@gmail.com>	
	Sun, 22 Jun 2014 14:17:06 +0000 (15:17 +0100)
committer	James Lowe <pkx166h@gmail.com>	
	Tue, 15 Jul 2014 16:32:12 +0000 (17:32 +0100)
commit	59570bd51f91b853a4a49ea434dee9aa06f50d65