Issue 107900045: code review 107900045: [release-branch.go1.3] cmd/ld: fix PC deltas in DWARF l...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 107900045: code review 107900045: [release-branch.go1.3] cmd/ld: fix PC deltas in DWARF l... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 10 months ago by rsc

Modified:
9 years, 10 months ago

Reviewers:
r, gobot

CC:
golang-codereviews, r, bradfitz, iant

Visibility:
Public.

Description

[release-branch.go1.3] cmd/ld: fix PC deltas in DWARF line number table ««« CL 104950045 / 87daa424d96a cmd/ld: fix PC deltas in DWARF line number table The putpclcdelta function set the DWARF line number PC to s->value + pcline->pc, which is correct, but the code then set the local variable pc to epc, which can be a different value. This caused the next delta in the DWARF table to be wrong. Fixes issue 8098. LGTM=rsc R=rsc CC=golang-codereviews https://codereview.appspot.com/104950045 »»»

Patch Set 1 #

Patch Set 2 : diff -r 96c74cf6dc10 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 2edde912fcd6 https://code.google.com/p/go/ #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	src/cmd/ld/dwarf.c	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

rsc

Hello golang-codereviews@googlegroups.com (cc: bradfitz, iant), I'd like you to review this change to https://code.google.com/p/go/

9 years, 10 months ago (2014-06-11 18:40:32 UTC) #1

rsc

*** Submitted as https://code.google.com/p/go/source/detail?r=8fc565eea9a0 *** [release-branch.go1.3] cmd/ld: fix PC deltas in DWARF line number table ...

9 years, 10 months ago (2014-06-11 20:55:37 UTC) #4

gobot

9 years, 10 months ago (2014-06-11 23:21:48 UTC) #5

Message was sent while issue was closed.

This CL appears to have broken the netbsd-amd64-bsiegert builder.
See http://build.golang.org/log/e0b65966c62fad3aef97cf57f0baa3e07b0cc8bd

Expand All Messages | Collapse All Messages