Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(5759)

Issue 107900045: code review 107900045: [release-branch.go1.3] cmd/ld: fix PC deltas in DWARF l... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 5 months ago by rsc
Modified:
5 years, 5 months ago
Reviewers:
r, gobot
CC:
golang-codereviews, r, bradfitz, iant
Visibility:
Public.

Description

[release-branch.go1.3] cmd/ld: fix PC deltas in DWARF line number table ««« CL 104950045 / 87daa424d96a cmd/ld: fix PC deltas in DWARF line number table The putpclcdelta function set the DWARF line number PC to s->value + pcline->pc, which is correct, but the code then set the local variable pc to epc, which can be a different value. This caused the next delta in the DWARF table to be wrong. Fixes issue 8098. LGTM=rsc R=rsc CC=golang-codereviews https://codereview.appspot.com/104950045 »»»

Patch Set 1 #

Patch Set 2 : diff -r 96c74cf6dc10 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 2edde912fcd6 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/cmd/ld/dwarf.c View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5
rsc
Hello golang-codereviews@googlegroups.com (cc: bradfitz, iant), I'd like you to review this change to https://code.google.com/p/go/
5 years, 5 months ago (2014-06-11 18:40:32 UTC) #1
r
LGTM
5 years, 5 months ago (2014-06-11 20:51:26 UTC) #2
r
LGTM
5 years, 5 months ago (2014-06-11 20:51:30 UTC) #3
rsc
*** Submitted as https://code.google.com/p/go/source/detail?r=8fc565eea9a0 *** [release-branch.go1.3] cmd/ld: fix PC deltas in DWARF line number table ...
5 years, 5 months ago (2014-06-11 20:55:37 UTC) #4
gobot
5 years, 5 months ago (2014-06-11 23:21:48 UTC) #5
Message was sent while issue was closed.
This CL appears to have broken the netbsd-amd64-bsiegert builder.
See http://build.golang.org/log/e0b65966c62fad3aef97cf57f0baa3e07b0cc8bd
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b