Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(675)

Issue 10788043: Implement more methods in the Azure provider.

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 9 months ago by rvb
Modified:
10 years, 9 months ago
Reviewers:
jameinel, mp+171966
Visibility:
Public.

Description

Implement more methods in the Azure provider. In the Azure provider, this branch implements environ's Instances() and AllInstances() methods and instance's Id(), DNSName() and WaitDNSName() methods. Nothing particularly noteworthy about the implementation: all the methods are implemented by doing simple calls to gwacl's methods. The tests are made relatively simple by the usage of the new test utility methods that gwacl provides. You'll see that I have decided, in tests, to only check that _a_ request was made to the fake Azure server rather that checking the exact nature of the request. The gwacl methods are themselves properly unittested so I decided it would do more bad than good to put too much Azure-specific stuff (such as the requested url) in the provider's test code. https://code.launchpad.net/~rvb/juju-core/az-list-instances/+merge/171966 (do not edit description out of merge proposal)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+190 lines, -13 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M environs/azure/environ.go View 1 chunk +62 lines, -2 lines 0 comments Download
M environs/azure/environ_test.go View 3 chunks +69 lines, -1 line 0 comments Download
M environs/azure/instance.go View 1 chunk +16 lines, -10 lines 0 comments Download
A environs/azure/instance_test.go View 1 chunk +41 lines, -0 lines 0 comments Download

Messages

Total messages: 2
rvb
Please take a look.
10 years, 9 months ago (2013-06-29 14:38:03 UTC) #1
jameinel
10 years, 9 months ago (2013-07-01 10:18:46 UTC) #2
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b