Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(24)

Issue 107690044: update HACKING.md

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 9 months ago by jrwren
Modified:
9 years, 9 months ago
Reviewers:
rharding, mp+226194
Visibility:
Public.

Description

update HACKING.md note that ppa stable is required New devs might assume that ppa:juju/devel subsumes ppa:juju/stable. Note that it does not. add Proposing Branches section to document use of lbox https://code.launchpad.net/~evarlast/charms/precise/juju-gui/hacking-note/+merge/226194 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : update HACKING.md #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -1 line) Patch
M HACKING.md View 2 chunks +26 lines, -0 lines 0 comments Download
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M hooks/utils.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
jrwren
Please take a look.
9 years, 9 months ago (2014-07-09 18:43:21 UTC) #1
rharding
LGTM thanks for this. Feel free to submit it.
9 years, 9 months ago (2014-07-09 18:54:30 UTC) #2
jrwren
9 years, 9 months ago (2014-07-09 19:33:41 UTC) #3
*** Submitted:

update HACKING.md

note that ppa stable is required
  New devs might assume that ppa:juju/devel subsumes ppa:juju/stable.
  Note that it does not.

add Proposing Branches section to document use of lbox

R=rharding
CC=
https://codereview.appspot.com/107690044
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b