Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(126)

Issue 10747044: code review 10747044: net/http: fix memory leak in Transport (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 10 months ago by bradfitz
Modified:
8 years, 10 months ago
Reviewers:
r
CC:
golang-dev, r
Visibility:
Public.

Description

net/http: fix memory leak in Transport Fixes issue 5794

Patch Set 1 #

Patch Set 2 : diff -r 8648a001bbca https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 8648a001bbca https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 56762832416a https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -1 line) Patch
M src/pkg/net/http/export_test.go View 1 1 chunk +6 lines, -0 lines 0 comments Download
M src/pkg/net/http/transport.go View 1 4 chunks +15 lines, -1 line 0 comments Download
M src/pkg/net/http/transport_test.go View 1 1 chunk +35 lines, -0 lines 0 comments Download

Messages

Total messages: 3
bradfitz
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
8 years, 10 months ago (2013-06-28 19:16:17 UTC) #1
r
LGTM
8 years, 10 months ago (2013-06-28 19:51:58 UTC) #2
bradfitz
8 years, 10 months ago (2013-06-28 19:57:58 UTC) #3
*** Submitted as https://code.google.com/p/go/source/detail?r=1e659829d22a ***

net/http: fix memory leak in Transport

Fixes issue 5794

R=golang-dev, r
CC=golang-dev
https://codereview.appspot.com/10747044
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b