Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(949)

Issue 107410044: [observe-js] add hasEval check before eval %RunMicrotasks() (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 9 months ago by John Messerly
Modified:
9 years, 9 months ago
Reviewers:
arv, rafaelw
CC:
sorvell
Base URL:
ssh://github.com/Polymer/observe-js.git@master
Visibility:
Public.

Description

add hasEval check to %RunMicrotasks() fixes https://github.com/Polymer/observe-js/issues/44#issuecomment-47515556 R=arv@chromium.org, rafaelw@chromium.org Committed: https://github.com/Polymer/observe-js/commit/fc8d439

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/observe.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4
John Messerly
This fixes the issue commented on -- specifically a CSP error from Chrome Apps due ...
9 years, 9 months ago (2014-07-01 00:37:19 UTC) #1
rafaelw
lgtm. thanks, john.
9 years, 9 months ago (2014-07-01 01:11:43 UTC) #2
arv
lgtm
9 years, 9 months ago (2014-07-01 14:20:59 UTC) #3
John Messerly
9 years, 9 months ago (2014-07-01 19:08:38 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as rfc8d439 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b