Issue 107230043: code review 107230043: goprotobuf: Fix bug in GetExtensions.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 107230043: code review 107230043: goprotobuf: Fix bug in GetExtensions. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 5 months ago by dsymonds

Modified:
11 years, 5 months ago

Reviewers:
nigeltao

CC:
nigeltao, golang-codereviews

Visibility:
Public.

Description

goprotobuf: Fix bug in GetExtensions. It is documented to return nil when an extension is missing; we weren't doing that.

Patch Set 1 #

Patch Set 2 : diff -r cbd7916e5dce https://code.google.com/p/goprotobuf #

Patch Set 3 : diff -r cbd7916e5dce https://code.google.com/p/goprotobuf #

Patch Set 4 : diff -r cbd7916e5dce https://code.google.com/p/goprotobuf #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+63 lines, -0 lines)			Patch
	M	proto/extensions.go	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
	A	proto/extensions_test.go	View	1	1 chunk	+60 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

dsymonds

Hello nigeltao (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/goprotobuf

11 years, 5 months ago (2014-06-20 03:07:36 UTC) #1

dsymonds

11 years, 5 months ago (2014-06-20 04:29:02 UTC) #3

*** Submitted as
https://code.google.com/p/goprotobuf/source/detail?r=d7fff2a870af ***

goprotobuf: Fix bug in GetExtensions.

It is documented to return nil when an extension is missing;
we weren't doing that.

LGTM=nigeltao
R=nigeltao
CC=golang-codereviews
https://codereview.appspot.com/107230043

Expand All Messages | Collapse All Messages