Issue 10683043: Bug fix for lp:1191066

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 10683043: Bug fix for lp:1191066

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 10 months ago by mattyw

Modified:
10 years, 10 months ago

Reviewers:
dimitern, jameinel, mp+171782

Visibility:
Public.

Description

Bug fix for lp:1191066 juju ssh can take a unit name rather than a service name, also agent. was making gofmt sad https://code.launchpad.net/~mattyw/juju-core/1191066/+merge/171782 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Bug fix for lp:1191066 #

Patch Set 3 : Bug fix for lp:1191066 #

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -2 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	cmd/juju/ssh.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	cmd/jujud/agent.go	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

LGTM, but please link the MP to the bug.

Expand All Messages | Collapse All Messages