Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1212)

Issue 10682043: charm: allow empty string as default value (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 9 months ago by mue
Modified:
10 years, 8 months ago
Reviewers:
mp+171779, dimitern, fwereade
Visibility:
Public.

Description

charm: allow empty string as default value The current solution is incompatible to pyjuju, where empty strings as default values are allowed. Added this as an exceptional case to the charm config. https://code.launchpad.net/~themue/juju-core/032-config-default-empty-string/+merge/171779 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 8

Patch Set 2 : charm: allow empty string as default value #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -1 line) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M charm/config.go View 1 1 chunk +3 lines, -1 line 1 comment Download
M charm/config_test.go View 1 4 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 5
mue
Please take a look.
10 years, 9 months ago (2013-06-27 11:55:37 UTC) #1
dimitern
A few thoughts https://codereview.appspot.com/10682043/diff/1/charm/config.go File charm/config.go (right): https://codereview.appspot.com/10682043/diff/1/charm/config.go#newcode114 charm/config.go:114: // Empty default string is an ...
10 years, 9 months ago (2013-06-27 15:01:20 UTC) #2
fwereade
LGTM with quibbles. https://codereview.appspot.com/10682043/diff/1/charm/config.go File charm/config.go (left): https://codereview.appspot.com/10682043/diff/1/charm/config.go#oldcode117 charm/config.go:117: } I would personally find something ...
10 years, 9 months ago (2013-06-28 09:32:11 UTC) #3
mue
Please take a look. https://codereview.appspot.com/10682043/diff/1/charm/config.go File charm/config.go (left): https://codereview.appspot.com/10682043/diff/1/charm/config.go#oldcode117 charm/config.go:117: } On 2013/06/28 09:32:11, fwereade ...
10 years, 9 months ago (2013-06-28 13:15:57 UTC) #4
dimitern
10 years, 9 months ago (2013-06-28 14:09:59 UTC) #5
LGTM

https://codereview.appspot.com/10682043/diff/8001/charm/config.go
File charm/config.go (right):

https://codereview.appspot.com/10682043/diff/8001/charm/config.go#newcode114
charm/config.go:114: if def == "" && option.Type == "string" {
much nicer, thanks!
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b