Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(203)

Issue 10679044: code review 10679044: go.talks/pkg/present: permit links inside words (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 6 months ago by adg
Modified:
7 years, 6 months ago
Reviewers:
r
CC:
golang-dev, r
Visibility:
Public.

Description

go.talks/pkg/present: permit links inside words This allows links inside parens ([[http://example.com/][for example]]).

Patch Set 1 #

Patch Set 2 : diff -r 8068452134af https://code.google.com/p/go.talks #

Patch Set 3 : diff -r 8068452134af https://code.google.com/p/go.talks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -21 lines) Patch
M pkg/present/style.go View 1 1 chunk +37 lines, -21 lines 0 comments Download
M pkg/present/style_test.go View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 4
adg
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go.talks
7 years, 6 months ago (2013-06-28 02:25:20 UTC) #1
adg
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), Please take another look.
7 years, 6 months ago (2013-06-28 02:25:36 UTC) #2
r
LGTM
7 years, 6 months ago (2013-06-28 05:49:41 UTC) #3
adg
7 years, 6 months ago (2013-06-29 05:07:44 UTC) #4
*** Submitted as
https://code.google.com/p/go/source/detail?r=58596207d038&repo=talks ***

go.talks/pkg/present: permit links inside words

This allows links inside parens ([[http://example.com/][for example]]).

R=golang-dev, r
CC=golang-dev
https://codereview.appspot.com/10679044
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b