code review 106290044: oauth: fix formatting warnings reported by go vet

oauth: fix formatting warnings reported by go vet

  oauth/oauth_test.go:158: possible formatting directive in Error call
  oauth/example/oauthreq.go:70: Println call ends with newline

[patrick2, 2014-06-29 12:14:03]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/goauth2

[gobot, 2014-06-29 12:17:10]

Replacing golang-dev with golang-codereviews.

To the author of this CL: 

If you are using 'hg mail -r golang-dev' to mail the CL, use simply 'hg mail'
instead.

If you did not name golang-dev explicitly and it was still added to the CL,
it means your working copy of the repo has a stale codereview.cfg
(or lib/codereview/codereview.cfg).
Please run 'hg sync' to update your client to the most recent codereview.cfg.
If the most recent codereview.cfg has defaultcc set to golang-dev instead of
golang-codereviews, please send a CL correcting it.

Thanks very much.

[bradfitz, 2014-06-29 18:19:35]

R=adg



On Sun, Jun 29, 2014 at 5:14 AM, <patrick@mezard.eu> wrote:

> Reviewers: golang-dev,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/goauth2
>
>
> Description:
> oauth: fix formatting warnings reported by go vet
>
>   oauth/oauth_test.go:158: possible formatting directive in Error call
>   oauth/example/oauthreq.go:70: Println call ends with newline
>
>
>
> Please review this at https://codereview.appspot.com/106290044/
>
> Affected files (+2, -2 lines):
>   M oauth/example/oauthreq.go
>   M oauth/oauth_test.go
>
>
> Index: oauth/example/oauthreq.go
> ===================================================================
> --- a/oauth/example/oauthreq.go
> +++ b/oauth/example/oauthreq.go
> @@ -67,7 +67,7 @@
>                         // Get an authorization code from the data
> provider.
>                         // ("Please ask the user if I can access this
> resource.")
>                         url := config.AuthCodeURL("")
> -                       fmt.Println("Visit this URL to get a code, then
> run again with -code=YOUR_CODE\n")
> +                       fmt.Printf("Visit this URL to get a code, then run
> again with -code=YOUR_CODE\n\n")
>                         fmt.Println(url)
>                         return
>                 }
> Index: oauth/oauth_test.go
> ===================================================================
> --- a/oauth/oauth_test.go
> +++ b/oauth/oauth_test.go
> @@ -155,7 +155,7 @@
>  func checkBody(t *testing.T, r *http.Response, body string) {
>         b, err := ioutil.ReadAll(r.Body)
>         if err != nil {
> -               t.Error("reading reponse body: %v, want %q", err, body)
> +               t.Errorf("reading reponse body: %v, want %q", err, body)
>         }
>         if g, w := string(b), body; g != w {
>                 t.Errorf("request body mismatch: got %q, want %q", g, w)
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-dev+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

[patrick2, 2014-06-30 18:27:47]

Changed to use fmt.Print instead of fmt.Printf.

PTAL.

[adg, 2014-07-06 21:21:01]

I get an "old chunk mismatch" viewing one of the diffs. Please run "hg upload
106290044" again.

[patrick2, 2014-07-07 18:07:06]

I rebased it but I do not expect anything to change. I probably have a problem
on my side if you cannot import it.

PTAL.

[adg, 2014-07-07 21:05:40]

LGTM

[adg, 2014-07-07 21:05:56]

*** Submitted as https://code.google.com/p/goauth2/source/detail?r=3770ceaf9ff8
***

oauth: fix formatting warnings reported by go vet

  oauth/oauth_test.go:158: possible formatting directive in Error call
  oauth/example/oauthreq.go:70: Println call ends with newline

LGTM=adg
R=golang-codereviews, bradfitz, adg
CC=golang-codereviews
https://codereview.appspot.com/106290044

Committer: Andrew Gerrand <adg@golang.org>