Issue 105170044: code review 105170044: go1.3rc2

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 105170044: code review 105170044: go1.3rc2 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 10 months ago by adg

Modified:
9 years, 10 months ago

Reviewers:
gobot, minux, rsc

CC:
golang-codereviews, minux, rsc

Visibility:
Public.

Description

go1.3rc2

Patch Set 1 #

Patch Set 2 : diff -r 67de4afa60e7 https://code.google.com/p/go #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	VERSION	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

adg

Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go

9 years, 10 months ago (2014-06-13 02:53:31 UTC) #1

minux

It seems Rietveld incoming mail is still broken. LGTM again.

9 years, 10 months ago (2014-06-13 03:01:57 UTC) #2

adg

*** Submitted as https://code.google.com/p/go/source/detail?r=3f66a43d5180 *** go1.3rc2 LGTM=minux, rsc R=golang-codereviews, minux, rsc CC=golang-codereviews https://codereview.appspot.com/105170044

9 years, 10 months ago (2014-06-13 03:25:01 UTC) #4

gobot

9 years, 10 months ago (2014-06-13 05:02:33 UTC) #5

Message was sent while issue was closed.

This CL appears to have broken the windows-amd64-race builder.
See http://build.golang.org/log/ff47f3c8fb5a46a5caf1db3b552e2770bc101ddd

Expand All Messages | Collapse All Messages