code review 10514046: crypto/sha1: mark block as non-escaping

crypto/sha1: mark block as non-escaping
The compiler still gets the escape analysis wrong, but the annotation here is correct.

[r, 2013-06-25 00:25:04]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go

[dfc, 2013-06-25 00:28:18]

LGTM. I'm sure you're already doing so, but please raise a bug for the
compiler misstep.

On Tue, Jun 25, 2013 at 10:25 AM,  <r@golang.org> wrote:
> Reviewers: golang-dev1,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go
>
>
> Description:
> crypto/sha1: mark block as non-escaping
> The compiler still gets the escape analysis wrong, but the annotation
> here is correct.
>
> Please review this at https://codereview.appspot.com/10514046/
>
> Affected files:
>   M src/pkg/crypto/sha1/sha1block_decl.go
>
>
> Index: src/pkg/crypto/sha1/sha1block_decl.go
> ===================================================================
> --- a/src/pkg/crypto/sha1/sha1block_decl.go
> +++ b/src/pkg/crypto/sha1/sha1block_decl.go
> @@ -6,4 +6,6 @@
>
>  package sha1
>
> +//go:noescape
> +
>  func block(dig *digest, p []byte)
>
>
> --
>
> ---You received this message because you are subscribed to the Google Groups
> "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-dev+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
>
>

[bradfitz, 2013-06-25 00:30:57]

LGTM



On Mon, Jun 24, 2013 at 5:25 PM, <r@golang.org> wrote:

> Reviewers: golang-dev1,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go
>
>
> Description:
> crypto/sha1: mark block as non-escaping
> The compiler still gets the escape analysis wrong, but the annotation
> here is correct.
>
> Please review this at
https://codereview.appspot.**com/10514046/<https://codereview.appspot.com/105...
>
> Affected files:
>   M src/pkg/crypto/sha1/sha1block_**decl.go
>
>
> Index: src/pkg/crypto/sha1/sha1block_**decl.go
> ==============================**==============================**=======
> --- a/src/pkg/crypto/sha1/**sha1block_decl.go
> +++ b/src/pkg/crypto/sha1/**sha1block_decl.go
> @@ -6,4 +6,6 @@
>
>  package sha1
>
> +//go:noescape
> +
>  func block(dig *digest, p []byte)
>
>
> --
>
> ---You received this message because you are subscribed to the Google
> Groups "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to
golang-dev+unsubscribe@**googlegroups.com<golang-dev%2Bunsubscribe@googlegrou...
> .
> For more options, visit
https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/o...
> .
>
>
>

[r, 2013-06-25 00:48:34]

*** Submitted as https://code.google.com/p/go/source/detail?r=415f87f63234 ***

crypto/sha1: mark block as non-escaping
The compiler still gets the escape analysis wrong, but the annotation here is
correct.

R=golang-dev, dave, bradfitz
CC=golang-dev
https://codereview.appspot.com/10514046