Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1157)

Issue 10507043: environ: initial writing of environments.yaml (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 9 months ago by mue
Modified:
10 years, 8 months ago
Reviewers:
mp+171134, fwereade, jameinel
Visibility:
Public.

Description

environ: initial writing of environments.yaml The initial writing of the environments.yaml has so far been with mode 0755 for .juju and 0666 for the file itself. So it is world readable and keys and secrets are not protected. Now the directory is created with mode 0700 and the file written with mode 0600. https://code.launchpad.net/~themue/juju-core/030-juju-only-user-readable/+merge/171134 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 7

Patch Set 2 : environ: initial writing of environments.yaml #

Patch Set 3 : environ: initial writing of environments.yaml #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -10 lines) Patch
A [revision details] View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M environs/config.go View 1 2 2 chunks +23 lines, -6 lines 0 comments Download
M environs/config_test.go View 1 2 2 chunks +30 lines, -1 line 0 comments Download
M testing/environ.go View 1 2 chunks +9 lines, -3 lines 0 comments Download

Messages

Total messages: 5
mue
Please take a look.
10 years, 9 months ago (2013-06-24 16:40:04 UTC) #1
jameinel
LGTM though I do have some comments. https://codereview.appspot.com/10507043/diff/1/environs/config.go File environs/config.go (right): https://codereview.appspot.com/10507043/diff/1/environs/config.go#newcode149 environs/config.go:149: if err ...
10 years, 9 months ago (2013-06-25 10:42:39 UTC) #2
fwereade
LGTM with another test and due consideration given to the bikeshed. https://codereview.appspot.com/10507043/diff/1/environs/config.go File environs/config.go (right): ...
10 years, 9 months ago (2013-06-26 13:30:01 UTC) #3
mue
Please take a look. https://codereview.appspot.com/10507043/diff/1/environs/config.go File environs/config.go (right): https://codereview.appspot.com/10507043/diff/1/environs/config.go#newcode149 environs/config.go:149: if err == nil { ...
10 years, 9 months ago (2013-06-27 17:43:38 UTC) #4
mue
10 years, 9 months ago (2013-06-28 16:41:18 UTC) #5
Please take a look.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b