Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(5055)

Issue 10431047: Stop Documentation/ly-examples/orchestra.ly from redefining markup commands (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 10 months ago by dak
Modified:
10 years, 9 months ago
Reviewers:
Keith, Graham Percival
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Stop Documentation/ly-examples/orchestra.ly from redefining markup commands This does not seem required. This patch does _not_ address multiple warnings because of nested VerticalAxisGroup grobs. Removing the warnings is possible by removing the Axis_group_engraver from the MarkLine context definition, but this messes up the positions of the tempo marks.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -14 lines) Patch
M Documentation/ly-examples/orchestra.ly View 1 chunk +0 lines, -14 lines 0 comments Download

Messages

Total messages: 2
Keith
> Removing the warnings is possible by removing the > Axis_group_engraver from the MarkLine context ...
10 years, 10 months ago (2013-06-22 20:33:17 UTC) #1
Graham Percival
10 years, 10 months ago (2013-06-24 08:49:27 UTC) #2
LGTM.

FWIW, this piece was composed and typeset by one of our blind users.  It's
amazing that he creates tweaks, but without being able to see their effects it's
not surprising that some of those tweaks turn out to be unnecessary.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b