code review 10431044: go.crypto/ocsp: make the zero value of RequestOptions v...

go.crypto/ocsp: make the zero value of RequestOptions valid and documented.

[agl1, 2013-06-21 19:14:09]

Hello bradfitz@golang.org (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go.crypto/

[bradfitz, 2013-06-21 19:15:16]

LGTM
 On Jun 21, 2013 12:14 PM, <agl@golang.org> wrote:

> Reviewers: bradfitz,
>
> Message:
> Hello bradfitz@golang.org (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change to
> https://code.google.com/p/go.**crypto/<https://code.google.com/p/go.crypto/>
>
>
> Description:
> go.crypto/ocsp: make the zero value of RequestOptions valid and
> documented.
>
> Please review this at
https://codereview.appspot.**com/10431044/<https://codereview.appspot.com/104...
>
> Affected files:
>   M ocsp/ocsp.go
>
>
> Index: ocsp/ocsp.go
> ==============================**==============================**=======
> --- a/ocsp/ocsp.go
> +++ b/ocsp/ocsp.go
> @@ -261,12 +261,12 @@
>  // RequestOptions contains options for constructing OCSP requests.
>  type RequestOptions struct {
>         // Hash contains the hash function that should be used when
> -       // constructing the OCSP request.
> +       // constructing the OCSP request. If zero, SHA-1 will be used.
>         Hash crypto.Hash
>  }
>
>  func (opts *RequestOptions) hash() crypto.Hash {
> -       if opts == nil {
> +       if opts == nil || opts.Hash == 0 {
>                 // SHA-1 is nearly universally used in OCSP.
>                 return crypto.SHA1
>         }
>
>
>

[agl1, 2013-06-21 19:16:34]

*** Submitted as
https://code.google.com/p/go/source/detail?r=1f2453f1ed54&repo=crypto ***

go.crypto/ocsp: make the zero value of RequestOptions valid and documented.

R=bradfitz
CC=golang-dev
https://codereview.appspot.com/10431044