Remove Metadata() method from Instance interface

Remove Metadata() method from Instance interface

The machine metadata is not aways available, and is only used
when startInstance is called. So have startInstance return the
metadata separately along with the instance.

https://code.launchpad.net/~wallyworld/juju-core/tweak-instance-metadata-api/+merge/170483

(do not edit description out of merge proposal)

[wallyworld, 2013-06-20 04:32:57]

Please take a look.

[wallyworld, 2013-06-20 07:56:20]

Please take a look.

[fwereade, 2013-06-21 10:42:13]

LGTM. We'll see how long we can put off the no-bootstrap-metadata issue, I don't
think it should be a blocker for us.

https://codereview.appspot.com/10384049/diff/9001/environs/ec2/ec2.go
File environs/ec2/ec2.go (right):

https://codereview.appspot.com/10384049/diff/9001/environs/ec2/ec2.go#newcode281
environs/ec2/ec2.go:281: // TODO(wallyworld) - save bootstrap machine metadata
Hmm. I guess we will need a Metadata() (or HardwareCharacteristics, bikeshed
bikeshed bikeshed) method on instance eventually. I'm still +1 on this change
for now though.

https://codereview.appspot.com/10384049/diff/9001/environs/maas/environ.go
File environs/maas/environ.go (right):

https://codereview.appspot.com/10384049/diff/9001/environs/maas/environ.go#ne...
environs/maas/environ.go:366: // TODO(wallyworld) - return instance metadata as
well
Would you ping someone on red and find out what we'd need to do this right? If
it can't be addressed immediately it needs a bug.

[thumper, 2013-06-24 01:48:05]

On 2013/06/21 10:42:13, fwereade wrote:
> LGTM. We'll see how long we can put off the no-bootstrap-metadata issue, I
don't
> think it should be a blocker for us.
> 
> https://codereview.appspot.com/10384049/diff/9001/environs/ec2/ec2.go
> File environs/ec2/ec2.go (right):
> 
>
https://codereview.appspot.com/10384049/diff/9001/environs/ec2/ec2.go#newcode281
> environs/ec2/ec2.go:281: // TODO(wallyworld) - save bootstrap machine metadata
> Hmm. I guess we will need a Metadata() (or HardwareCharacteristics, bikeshed
> bikeshed bikeshed) method on instance eventually. I'm still +1 on this change
> for now though.
> 
> https://codereview.appspot.com/10384049/diff/9001/environs/maas/environ.go
> File environs/maas/environ.go (right):
> 
>
https://codereview.appspot.com/10384049/diff/9001/environs/maas/environ.go#ne...
> environs/maas/environ.go:366: // TODO(wallyworld) - return instance metadata
as
> well
> Would you ping someone on red and find out what we'd need to do this right? If
> it can't be addressed immediately it needs a bug.

LGTM, don't care about bikeshedding the name right now.

[wallyworld, 2013-06-24 05:31:42]

https://codereview.appspot.com/10384049/diff/9001/environs/ec2/ec2.go
File environs/ec2/ec2.go (right):

https://codereview.appspot.com/10384049/diff/9001/environs/ec2/ec2.go#newcode281
environs/ec2/ec2.go:281: // TODO(wallyworld) - save bootstrap machine metadata
On 2013/06/21 10:42:14, fwereade wrote:
> Hmm. I guess we will need a Metadata() (or HardwareCharacteristics, bikeshed
> bikeshed bikeshed) method on instance eventually. I'm still +1 on this change
> for now though.

I've repainted the bikeshed.

https://codereview.appspot.com/10384049/diff/9001/environs/maas/environ.go
File environs/maas/environ.go (right):

https://codereview.appspot.com/10384049/diff/9001/environs/maas/environ.go#ne...
environs/maas/environ.go:366: // TODO(wallyworld) - return instance metadata as
well
On 2013/06/21 10:42:14, fwereade wrote:
> Would you ping someone on red and find out what we'd need to do this right? If
> it can't be addressed immediately it needs a bug.

Red says easy to do. Bug raised 1193998

[dfc, 2013-06-24 06:44:31]

LGTM, very nice, i like where this is going.

https://codereview.appspot.com/10384049/diff/9001/environs/azure/environ.go
File environs/azure/environ.go (right):

https://codereview.appspot.com/10384049/diff/9001/environs/azure/environ.go#n...
environs/azure/environ.go:78: panic("unimplemented")
not nil, nil, errors.New("not implemented") ?