Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4297)

Issue 10269043: flag: Use camelCase instead of snake_case for local var... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 10 months ago by Dominik Honnef
Modified:
10 years, 8 months ago
Reviewers:
gri, rog
Visibility:
Public.

Description

flag: Use camelCase instead of snake_case for local variables

Patch Set 1 #

Patch Set 2 : diff -r 4068527655f3 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M src/pkg/flag/flag.go View 1 3 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 3
gri
I can't get excited about these - it's completely internal. We do have a CamelCase ...
10 years, 10 months ago (2013-06-13 16:43:18 UTC) #1
Dominik Honnef
Yeah, I can see how these changes might be perceived as going "over the top". ...
10 years, 10 months ago (2013-06-13 16:51:26 UTC) #2
rog
10 years, 10 months ago (2013-06-13 17:11:22 UTC) #3
On 2013/06/13 16:51:26, Dominik Honnef wrote:
> Yeah, I can see how these changes might be perceived as going "over the top".
My
> main intention is to have one consistent style throughout the standard
library.
> For example archive/tar mixes both styles in the same package, where
snake_case
> was introduced by a 3rd party contribution.
> 
> But as I said, if it's not worth it, I won't bother with it.

i think it's worth fixing these as i think
it's worth passing cleanly through golint
when reasonable.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b