Issue 10268043: compress/flate: Various style changes

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 10268043: compress/flate: Various style changes (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 10 months ago by Dominik Honnef

Modified:
10 years, 8 months ago

Reviewers:
gri, rog

Visibility:
Public.

Description

compress/flate: Various style changes Compact variable declarations and use struct literals. Also bring the documentation for the Reader type in line with standard documentation style.

Patch Set 2 : diff -r 4068527655f3 https://code.google.com/p/go #

Total comments: 2

Patch Set 3 : diff -r 4068527655f3 https://code.google.com/p/go #

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -19 lines)			Patch
M	src/pkg/compress/flate/huffman_bit_writer.go	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/pkg/compress/flate/huffman_code.go	View	1	1 chunk	+4 lines, -2 lines	0 comments	Download
M	src/pkg/compress/flate/inflate.go	View	1	3 chunks	+19 lines, -15 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

gri

https://codereview.appspot.com/10268043/diff/2001/src/pkg/compress/flate/huffman_bit_writer.go File src/pkg/compress/flate/huffman_bit_writer.go (right): https://codereview.appspot.com/10268043/diff/2001/src/pkg/compress/flate/huffman_bit_writer.go#newcode294 src/pkg/compress/flate/huffman_bit_writer.go:294: var codeWord = int(w.codegen[i]) codeWord := int(w.codegen[i]) https://codereview.appspot.com/10268043/diff/2001/src/pkg/compress/flate/huffman_bit_writer.go#newcode397 src/pkg/compress/flate/huffman_bit_writer.go:397: ...

10 years, 10 months ago (2013-06-13 16:40:56 UTC) #1

rog

10 years, 10 months ago (2013-06-13 17:09:50 UTC) #2

On 2013/06/13 16:40:56, gri wrote:
>
https://codereview.appspot.com/10268043/diff/2001/src/pkg/compress/flate/huff...
> File src/pkg/compress/flate/huffman_bit_writer.go (right):
> 
>
https://codereview.appspot.com/10268043/diff/2001/src/pkg/compress/flate/huff...
> src/pkg/compress/flate/huffman_bit_writer.go:294: var codeWord =
> int(w.codegen[i])
> codeWord := int(w.codegen[i])
> 
>
https://codereview.appspot.com/10268043/diff/2001/src/pkg/compress/flate/huff...
> src/pkg/compress/flate/huffman_bit_writer.go:397: var storedSize =
> int64(math.MaxInt64)
> storedSize :=int64(math.MaxInt64)
> 
> or leave as is

LGTM

Expand All Messages | Collapse All Messages