Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1174)

Issue 10250043: code review 10250043: [release-branch.go1.1] cmd/gc: compute initialization o... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 9 months ago by adg
Modified:
10 years, 9 months ago
Reviewers:
iant
CC:
iant, rsc, golang-dev
Visibility:
Public.

Description

[release-branch.go1.1] cmd/gc: compute initialization order for top-level blank vars too. ««« CL 8601044 / 3a74e15c5d56 cmd/gc: compute initialization order for top-level blank vars too. Fixes issue 5244. R=golang-dev, rsc, iant, r, daniel.morsing CC=golang-dev https://codereview.appspot.com/8601044 »»»

Patch Set 1 #

Patch Set 2 : diff -r 3489b1de177e https://code.google.com/p/go #

Patch Set 3 : diff -r 3489b1de177e https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -4 lines) Patch
M src/cmd/gc/sinit.c View 1 2 chunks +2 lines, -4 lines 0 comments Download
A test/fixedbugs/issue5244.go View 1 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 3
adg
Hello iant, rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
10 years, 9 months ago (2013-06-13 00:04:57 UTC) #1
iant
LGTM
10 years, 9 months ago (2013-06-13 00:27:25 UTC) #2
adg
10 years, 9 months ago (2013-06-13 00:30:52 UTC) #3
*** Submitted as https://code.google.com/p/go/source/detail?r=10ace6ccf503 ***

[release-branch.go1.1] cmd/gc: compute initialization order for top-level blank
vars too.

««« CL 8601044 / 3a74e15c5d56
cmd/gc: compute initialization order for top-level blank vars too.

Fixes issue 5244.

R=golang-dev, rsc, iant, r, daniel.morsing
CC=golang-dev
https://codereview.appspot.com/8601044
»»»

R=iant, rsc
CC=golang-dev
https://codereview.appspot.com/10250043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b