Color and/or parenthesize single dots in fret-diagrams

Color and/or parenthesize single dots in fret-diagrams

Issue 2752

Makes it possible to color and/or parenthesize single dots in
fret-diagram-verbose

Introducing two properties for use in fret-diagram-details
 - fret-label-horizontal-offset
    affecting the fret-label-indication, like the existing
    `fret-label-vertical-offset'
 - paren-padding
    affecting the padding of the parenthesis

Extending relevant reg-tests.

Documenting it in NR, fretted-strings.itely

[thomasmorley651, 2014-06-14 16:57:24]

Please review

[pkx166h, 2014-06-14 18:48:14]

https://codereview.appspot.com/102450043/diff/1/Documentation/notation/frette...
File Documentation/notation/fretted-strings.itely (right):

https://codereview.appspot.com/102450043/diff/1/Documentation/notation/frette...
Documentation/notation/fretted-strings.itely:1002: color.
We need a new (obvious) paragraph for this new text I think, so give a line
space after the previous one.

The syntax is a bit uncomfortable I think. Are they really just called 'dots'?

Here's my suggestion:

"Fingering indication dots can be colored as well as parenthesized; the
parenthesis's color can also be altered independently."

The example will show the subtleties of 'inversion' and 'modification'.

[marc, 2014-06-15 07:46:22]

Hi Harm,

great work, mostly LGTM, just two small nitpicks.

https://codereview.appspot.com/102450043/diff/1/scm/fret-diagrams.scm
File scm/fret-diagrams.scm (right):

https://codereview.appspot.com/102450043/diff/1/scm/fret-diagrams.scm#newcode119
scm/fret-diagrams.scm:119: ;; parantheses
typo: parentheses or -is

https://codereview.appspot.com/102450043/diff/1/scm/fret-diagrams.scm#newcode...
scm/fret-diagrams.scm:1096: The values for @var{string-number},
@var{fret-number}, and @var{finger}
This description is not precise IMHO. The first values have to be in that order.
Do I have to code a value for finger before I use one ore more of the optional
arguments?
Would (place-fret 1 1 parenthesized) work?

[thomasmorley651, 2014-06-15 11:13:22]

Addressing Marc's and James' comments, updating reg-tests version

[thomasmorley651, 2014-06-15 11:18:55]

On 2014/06/14 18:48:14, J_lowe wrote:
>
https://codereview.appspot.com/102450043/diff/1/Documentation/notation/frette...
> File Documentation/notation/fretted-strings.itely (right):
> 
>
https://codereview.appspot.com/102450043/diff/1/Documentation/notation/frette...
> Documentation/notation/fretted-strings.itely:1002: color.
> We need a new (obvious) paragraph for this new text I think, so give a line
> space after the previous one.
> 
> The syntax is a bit uncomfortable I think. Are they really just called 'dots'?
> 
> Here's my suggestion:
> 
> "Fingering indication dots can be colored as well as parenthesized; the
> parenthesis's color can also be altered independently."
> 
> The example will show the subtleties of 'inversion' and 'modification'.

done

I highly appreciate any suggestion to improve my wording, syntax and grammar...
Sometimes I feel it's more difficult to write documentation than code.

[thomasmorley651, 2014-06-15 11:21:02]

On 2014/06/15 07:46:22, marc wrote:
> Hi Harm,
> 
> great work, mostly LGTM, just two small nitpicks.
> 
> https://codereview.appspot.com/102450043/diff/1/scm/fret-diagrams.scm
> File scm/fret-diagrams.scm (right):
> 
>
https://codereview.appspot.com/102450043/diff/1/scm/fret-diagrams.scm#newcode119
> scm/fret-diagrams.scm:119: ;; parantheses
> typo: parentheses or -is

done

>
https://codereview.appspot.com/102450043/diff/1/scm/fret-diagrams.scm#newcode...
> scm/fret-diagrams.scm:1096: The values for @var{string-number},
> @var{fret-number}, and @var{finger}
> This description is not precise IMHO. The first values have to be in that
order.

Hope it's better now.

> Do I have to code a value for finger before I use one ore more of the optional
> arguments?

no

> Would (place-fret 1 1 parenthesized) work?

yes, it will work