Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(843)

Issue 10242044: code review 10242044: [release-branch.go1.1] cmd/gc: save local var list befo... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 9 months ago by adg
Modified:
10 years, 9 months ago
Reviewers:
iant
CC:
iant, rsc, golang-dev
Visibility:
Public.

Description

[release-branch.go1.1] cmd/gc: save local var list before inlining ««« CL 10210043 / b357e33bb414 cmd/gc: save local var list before inlining This avoids problems with inlining in genwrappers, which occurs after functions have been compiled. Compiling a function may cause some unused local vars to be removed from the list. Since a local var may be unused due to optimization, it is possible that a removed local var winds up beingused in the inlined version, in which case hilarity ensues. Fixes issue 5515. R=golang-dev, khr, dave CC=golang-dev https://codereview.appspot.com/10210043 »»»

Patch Set 1 #

Patch Set 2 : diff -r 04ceae5a1650 https://code.google.com/p/go #

Patch Set 3 : diff -r 04ceae5a1650 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -2 lines) Patch
M src/cmd/gc/go.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/cmd/gc/inl.c View 1 2 chunks +3 lines, -2 lines 0 comments Download
A test/fixedbugs/issue5515.go View 1 1 chunk +34 lines, -0 lines 0 comments Download

Messages

Total messages: 3
adg
Hello iant, rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
10 years, 9 months ago (2013-06-12 23:47:25 UTC) #1
iant
LGTM
10 years, 9 months ago (2013-06-13 00:03:46 UTC) #2
adg
10 years, 9 months ago (2013-06-13 00:04:24 UTC) #3
*** Submitted as https://code.google.com/p/go/source/detail?r=3489b1de177e ***

[release-branch.go1.1] cmd/gc: save local var list before inlining

««« CL 10210043 / b357e33bb414
cmd/gc: save local var list before inlining

This avoids problems with inlining in genwrappers, which
occurs after functions have been compiled.  Compiling a
function may cause some unused local vars to be removed from
the list.  Since a local var may be unused due to
optimization, it is possible that a removed local var winds up
beingused in the inlined version, in which case hilarity
ensues.

Fixes issue 5515.

R=golang-dev, khr, dave
CC=golang-dev
https://codereview.appspot.com/10210043
»»»

R=iant, rsc
CC=golang-dev
https://codereview.appspot.com/10242044
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b