Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(319)

Issue 10237046: Implement storage methods in the Azure provider.

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 9 months ago by rvb
Modified:
10 years, 9 months ago
Reviewers:
mp+170622, wallyworld, jameinel
Visibility:
Public.

Description

Implement storage methods in the Azure provider. This branch implements 4 storage-related methods in the Azure provider: azureStorage.Get, azureStorage.List, azureStorage.Put and azureStorage.Remove. The implementations are rather straightforward: simple calls to gwacl with the occasional formatting of the returned data. Some abstractions (like the storageContext interface) were added for the sole purpose of being able to do some dependency injection in the tests. https://code.launchpad.net/~rvb/juju-core/az-storage/+merge/170622 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 10
Unified diffs Side-by-side diffs Delta from patch set Stats (+242 lines, -5 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M environs/azure/storage.go View 2 chunks +60 lines, -5 lines 6 comments Download
A environs/azure/storage_test.go View 1 chunk +180 lines, -0 lines 4 comments Download

Messages

Total messages: 6
rvb
Please take a look.
10 years, 9 months ago (2013-06-20 13:52:17 UTC) #1
wallyworld
Looks nice but there are a few things that need fixing. https://codereview.appspot.com/10237046/diff/1/environs/azure/storage.go File environs/azure/storage.go (right): ...
10 years, 9 months ago (2013-06-21 00:45:54 UTC) #2
rvb
Thanks for the review Ian. I've addressed the minor things you pointed out… but handling ...
10 years, 9 months ago (2013-06-21 07:59:48 UTC) #3
rvb
> https://codereview.appspot.com/10237046/diff/1/environs/azure/storage.go#newcode49 > environs/azure/storage.go:49: return nil, err > We need to check for a storage ...
10 years, 9 months ago (2013-06-21 15:13:15 UTC) #4
jameinel
just a response to the question about what is the URL use case. https://codereview.appspot.com/10237046/diff/1/environs/azure/storage.go File ...
10 years, 9 months ago (2013-06-23 11:42:22 UTC) #5
rvb
10 years, 9 months ago (2013-06-24 07:10:48 UTC) #6
On 2013/06/23 11:42:22, jameinel wrote:
> just a response to the question about what is the URL use case.
[...]
> I don't know what you want/need/are able to do in Azure.

Thanks a lot jam, this is exactly what I needed to know.  Azure has support for
public containers (but nothing comparable to the "SignedURL" functionality) so
the only option is probably something like what you've done for Openstack but
I'll look into this.

I'd rather get this branch landed now and do that in another branch though.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b