code review 102080043: cmd/cgo: use same Go type for typedef to anonymous struct

cmd/cgo: use same Go type for typedef to anonymous struct

If we see a typedef to an anonymous struct more than once,
presumably in two different Go files that import "C", use the
same Go type name.

Fixes issue 8133.

[iant, 2014-06-02 17:56:23]

Hello rsc (cc: golang-codereviews@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[rsc, 2014-06-02 19:20:59]

LGTM

[iant, 2014-06-02 19:55:48]

*** Submitted as https://code.google.com/p/go/source/detail?r=256d975c53cb ***

cmd/cgo: use same Go type for typedef to anonymous struct

If we see a typedef to an anonymous struct more than once,
presumably in two different Go files that import "C", use the
same Go type name.

Fixes issue 8133.

LGTM=rsc
R=rsc
CC=golang-codereviews
https://codereview.appspot.com/102080043

[gobot, 2014-06-02 19:58:58]

This CL appears to have broken the linux-386 builder.
See http://build.golang.org/log/785699884c069d24024523b57771b5bd03f8edef

[iant, 2014-06-02 20:08:02]

On Mon, Jun 2, 2014 at 12:58 PM,  <gobot@golang.org> wrote:
> This CL appears to have broken the linux-386 builder.
> See http://build.golang.org/log/785699884c069d24024523b57771b5bd03f8edef
>
> https://codereview.appspot.com/102080043/

Does not look related.

FAIL: TestDialTimeoutFDLeak (0.53 seconds)
dial_test.go:294: 149 good connects; expected at most 148
...