Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1604)

Issue 101820043: code review 101820043: armmap: arm decoder builder (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 10 months ago by rsc
Modified:
9 years, 10 months ago
Reviewers:
minux1
CC:
minux1, crawshaw
Visibility:
Public.

Description

armmap: arm decoder builder

Patch Set 1 #

Patch Set 2 : diff -r 0 https://code.google.com/p/rsc.arm/ #

Patch Set 3 : diff -r f7042ea3a978 https://code.google.com/p/rsc.arm/ #

Patch Set 4 : diff -r f7042ea3a978 https://code.google.com/p/rsc.arm/ #

Patch Set 5 : diff -r f7042ea3a978 https://code.google.com/p/rsc.arm/ #

Total comments: 7

Patch Set 6 : diff -r 35f93b19063c https://code.google.com/p/rsc.arm/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8379 lines, -0 lines) Patch
A arm.csv View 1 2 3 4 1 chunk +451 lines, -0 lines 0 comments Download
A armasm/Makefile View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
A armasm/tables.go View 1 2 3 4 1 chunk +7161 lines, -0 lines 0 comments Download
A armmap/map.go View 1 2 3 4 1 chunk +765 lines, -0 lines 0 comments Download

Messages

Total messages: 5
rsc
Hello crawshaw, I'd like you to review this change to https://code.google.com/p/rsc.arm/
9 years, 10 months ago (2014-05-28 00:03:26 UTC) #1
rsc
Hello minux.ma@gmail.com (cc: crawshaw@golang.org), Please take another look.
9 years, 10 months ago (2014-05-28 18:35:15 UTC) #2
crawshaw
Back Saturday, but it looks like minix will review. (Apparently there's one bar of internet ...
9 years, 10 months ago (2014-05-29 12:01:27 UTC) #3
minux1
LGTM. I didn't review the csv. https://codereview.appspot.com/101820043/diff/80001/armasm/Makefile File armasm/Makefile (right): https://codereview.appspot.com/101820043/diff/80001/armasm/Makefile#newcode2 armasm/Makefile:2: go run ../armmap/map.go ...
9 years, 10 months ago (2014-05-29 21:04:36 UTC) #4
rsc
9 years, 10 months ago (2014-05-31 13:35:13 UTC) #5
*** Submitted as
https://code.google.com/p/rsc/source/detail?r=005cf976534f&repo=arm ***

armmap: arm decoder builder

LGTM=minux.ma
R=minux.ma
CC=crawshaw
https://codereview.appspot.com/101820043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b