state: Unit.WatchConfigSettings

state: Unit.WatchConfigSettings

state.Settings is bad, because it allows any client the ability to
read/change the associated document without any sort of validation;
and sending them down a channel is independently bad because the
documents don't contain the right data for the unit context.

So, I just made it an EntityWatcher instead. Works just as well, is
rather simpler, doesn't expose massive potential bugs. Win!

https://code.launchpad.net/~fwereade/juju-core/config-4-state-unit-settings-watcher/+merge/168578

Requires: https://code.launchpad.net/~fwereade/juju-core/config-3-state-unit-settings-rename/+merge/168577

(do not edit description out of merge proposal)

[fwereade, 2013-06-11 01:56:13]

Please take a look.

[thumper, 2013-06-11 05:19:29]

On 2013/06/11 01:56:13, fwereade wrote:
> Please take a look.

LGTM

[wallyworld, 2013-06-11 08:11:28]

LGTM

[rog, 2013-06-11 12:13:27]

LGTM

https://codereview.appspot.com/10180043/diff/1/state/watcher.go
File state/watcher.go (right):

https://codereview.appspot.com/10180043/diff/1/state/watcher.go#newcode1038
state/watcher.go:1038: // TODO(fwereade): this could be much smarter; if it
were, uniter.Filter
perhaps say a tiny bit about how this could be smarter?
it's not obvious to me, at any rate.

[fwereade, 2013-06-12 00:30:20]

*** Submitted:

state: Unit.WatchConfigSettings

state.Settings is bad, because it allows any client the ability to
read/change the associated document without any sort of validation;
and sending them down a channel is independently bad because the
documents don't contain the right data for the unit context.

So, I just made it an EntityWatcher instead. Works just as well, is
rather simpler, doesn't expose massive potential bugs. Win!

R=thumper, wallyworld, rog
CC=
https://codereview.appspot.com/10180043

https://codereview.appspot.com/10180043/diff/1/state/watcher.go
File state/watcher.go (right):

https://codereview.appspot.com/10180043/diff/1/state/watcher.go#newcode1038
state/watcher.go:1038: // TODO(fwereade): this could be much smarter; if it
were, uniter.Filter
On 2013/06/11 12:13:27, rog wrote:
> perhaps say a tiny bit about how this could be smarter?
> it's not obvious to me, at any rate.

The restrictions are described in the preceding para -- it might be nice if it
incorporated a watch on the unit's charm url and switched source. But otoh it's
kind of a hassle to deal with and filter works well enough at the moment.