Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(731)

Issue 10178043: charm: trivial error consistency tweak

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 9 months ago by fwereade
Modified:
10 years, 9 months ago
Reviewers:
thumper, mp+168576, wallyworld
Visibility:
Public.

Description

charm: trivial error consistency tweak expect followup changing charm package to use errors.NotFoundError https://code.launchpad.net/~fwereade/juju-core/config-2-trivial-error-message-change/+merge/168576 Requires: https://code.launchpad.net/~fwereade/juju-core/config-1-rewrite-type/+merge/168575 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 6

Patch Set 2 : charm: trivial error consistency tweak #

Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -94 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M charm/repo.go View 1 chunk +1 line, -1 line 0 comments Download
M charm/repo_test.go View 1 13 chunks +99 lines, -92 lines 0 comments Download
M cmd/juju/upgradecharm_test.go View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5
fwereade
Please take a look.
10 years, 9 months ago (2013-06-11 01:46:20 UTC) #1
thumper
LGTM extra +1 if you rename curl to charmUrl :) https://codereview.appspot.com/10178043/diff/1/charm/repo_test.go File charm/repo_test.go (right): https://codereview.appspot.com/10178043/diff/1/charm/repo_test.go#newcode426 ...
10 years, 9 months ago (2013-06-11 05:14:45 UTC) #2
wallyworld
LGTM https://codereview.appspot.com/10178043/diff/1/charm/repo_test.go File charm/repo_test.go (right): https://codereview.appspot.com/10178043/diff/1/charm/repo_test.go#newcode416 charm/repo_test.go:416: func (s *LocalRepoSuite) checkNotFoundErr(c *C, err error, curl ...
10 years, 9 months ago (2013-06-11 08:03:33 UTC) #3
rog
looks reasonable, but what's the deal with the new errors package? https://codereview.appspot.com/10178043/diff/1/charm/repo.go File charm/repo.go (right): ...
10 years, 9 months ago (2013-06-11 12:04:55 UTC) #4
fwereade
10 years, 9 months ago (2013-06-11 23:55:32 UTC) #5
*** Submitted:

charm: trivial error consistency tweak

expect followup changing charm package to use errors.NotFoundError

R=thumper, wallyworld, rog
CC=
https://codereview.appspot.com/10178043

https://codereview.appspot.com/10178043/diff/1/charm/repo.go
File charm/repo.go (right):

https://codereview.appspot.com/10178043/diff/1/charm/repo.go#newcode295
charm/repo.go:295: return &NotFoundError{fmt.Sprintf("charm not found in %q:
%s", repoPath, curl)}
On 2013/06/11 12:04:55, rog wrote:
> shouldn't this be using errors.NotFoundf ?

Probably, yeah. Good catch. But it had some kinda tentacley aspects, am
preparing a new CL.

https://codereview.appspot.com/10178043/diff/1/charm/repo_test.go
File charm/repo_test.go (right):

https://codereview.appspot.com/10178043/diff/1/charm/repo_test.go#newcode426
charm/repo_test.go:426: curl := charm.MustParseURL(str)
On 2013/06/11 08:03:34, wallyworld wrote:
> +1. Please rename :-)
> Maybe even charmURL

The "curl" abbreviation is used a *lot*. I'll fix this file and try to remember
to fix other cases as I run across them.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b